From: "Chen, Yian" <yian.chen@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>,
Barret Rhoden <brho@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
David Woodhouse <dwmw2@infradead.org>,
Joerg Roedel <joro@8bytes.org>,
Sohil Mehta <sohil.mehta@intel.com>
Cc: iommu@lists.linux-foundation.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] iommu/vt-d bad RMRR workarounds
Date: Mon, 16 Dec 2019 11:11:37 -0800 [thread overview]
Message-ID: <c9e97080-eae3-efbd-0ba8-c4794f442c6b@intel.com> (raw)
In-Reply-To: <02d69d9a-9c45-d9e7-4c1a-cb5e50590c47@linux.intel.com>
On 12/13/2019 5:52 PM, Lu Baolu wrote:
>
> On 12/13/19 10:31 PM, Barret Rhoden wrote:
>> On 12/11/19 9:43 PM, Lu Baolu wrote:
>>> The VT-d spec defines the BIOS considerations about RMRR in section
>>> 8.4:
>>>
>>> "
>>> BIOS must report the RMRR reported memory addresses as reserved (or as
>>> EFI runtime) in the system memory map returned through methods such as
>>> INT15, EFI GetMemoryMap etc.
>>> "
>>>
>>> So we should treat it as firmware bug if the RMRR range is not
>>> mapped as
>>> RESERVED in the system memory map table.
>>>
>>> As for how should the driver handle this case, ignoring buggy RMRR with
>>> a warning message might be a possible choice.
>>
>> Agreed, firmware should not be doing this. My first patch just skips
>> those entries, instead of aborting DMAR processing, and keeps the
>> warning.
>>
>
> Hi Yian,
>
> Does this work for you?
>
> Best regards,
> baolu
>
>
I made a comment in the the patch email "[PATCH 1/3] iommu/vt-d: skip
RMRR entries that fail the sanity check "
thanks,
Yian
>> So long as the machine still boots in a safe manner, I'm reasonably
>> happy.
>>
>> Thanks,
>>
>> Barret
>>
>>
prev parent reply other threads:[~2019-12-16 19:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 19:46 [PATCH 0/3] iommu/vt-d bad RMRR workarounds Barret Rhoden
2019-12-11 19:46 ` [PATCH 1/3] iommu/vt-d: skip RMRR entries that fail the sanity check Barret Rhoden
2019-12-16 19:07 ` Chen, Yian
2019-12-16 19:35 ` Barret Rhoden
2019-12-17 19:19 ` Chen, Yian
2019-12-23 20:27 ` Barret Rhoden
2019-12-11 19:46 ` [PATCH 2/3] iommu/vt-d: treat unmapped RMRR entries as sane Barret Rhoden
2019-12-11 19:46 ` [PATCH 3/3] iommu/vt-d: skip invalid RMRR entries Barret Rhoden
2019-12-12 2:43 ` [PATCH 0/3] iommu/vt-d bad RMRR workarounds Lu Baolu
2019-12-13 14:31 ` Barret Rhoden
2019-12-14 1:52 ` Lu Baolu
2019-12-16 19:11 ` Chen, Yian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9e97080-eae3-efbd-0ba8-c4794f442c6b@intel.com \
--to=yian.chen@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bp@alien8.de \
--cc=brho@google.com \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).