From: Pekka Enberg <penberg@iki.fi>
To: Christopher Lameter <cl@linux.com>,
"Tobin C. Harding" <tobin@kernel.org>
Cc: Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slab: Increase width of first /proc/slabinfo column
Date: Sat, 2 Feb 2019 08:47:03 +0200 [thread overview]
Message-ID: <ca008d08-0041-5277-e562-5212783ea6be@iki.fi> (raw)
In-Reply-To: <01000168a6e8944d-b8e72739-2611-4649-a8d2-304b98529b7d-000000@email.amazonses.com>
Hi,
On 01/02/2019 4.34, Christopher Lameter wrote:
> On Fri, 1 Feb 2019, Tobin C. Harding wrote:
>
>> Currently when displaying /proc/slabinfo if any cache names are too long
>> then the output columns are not aligned. We could do something fancy to
>> get the maximum length of any cache name in the system or we could just
>> increase the hardcoded width. Currently it is 17 characters. Monitors
>> are wide these days so lets just increase it to 30 characters.
>
> Hmm.. I wonder if there are any tools that depend on the field width here?
>
It's possible, but it's more likely that userspace parses by whitespace
because it's easier to write it that way.
At least procps, which is used by slabtop, is prepared to parse a cache
name of 128 characters. See the scanf() call in parse_slabinfo20()
function in proc/slab.c of procps:
http://procps.sourceforge.net/
Of course, testing with slabtop would make sense.
- Pekka
next prev parent reply other threads:[~2019-02-02 6:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 0:42 [PATCH] mm/slab: Increase width of first /proc/slabinfo column Tobin C. Harding
2019-02-01 0:58 ` Tobin C. Harding
2019-02-01 1:13 ` Andrew Morton
2019-02-01 2:56 ` Tobin C. Harding
2019-02-01 2:34 ` Christopher Lameter
2019-02-02 6:47 ` Pekka Enberg [this message]
2019-02-01 2:43 ` Matthew Wilcox
2019-02-01 2:58 ` Tobin C. Harding
2019-02-01 22:03 ` Andrew Morton
2019-02-04 5:55 ` Tobin C. Harding
2019-02-04 1:35 ` Tobin C. Harding
2019-02-02 3:27 ` Joe Perches
2019-02-03 23:34 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca008d08-0041-5277-e562-5212783ea6be@iki.fi \
--to=penberg@iki.fi \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tobin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).