From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933264AbcK2R0O (ORCPT ); Tue, 29 Nov 2016 12:26:14 -0500 Received: from foss.arm.com ([217.140.101.70]:53254 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932680AbcK2R0F (ORCPT ); Tue, 29 Nov 2016 12:26:05 -0500 Subject: Re: [PATCH 16/22] arm64/cpuinfo: Convert to hotplug state machine To: Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org References: <20161126231350.10321-1-bigeasy@linutronix.de> <20161126231350.10321-17-bigeasy@linutronix.de> Cc: rt@linutronix.de, tglx@linutronix.de, Anna-Maria Gleixner , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org From: Suzuki K Poulose Message-ID: Date: Tue, 29 Nov 2016 17:26:02 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161126231350.10321-17-bigeasy@linutronix.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/11/16 23:13, Sebastian Andrzej Siewior wrote: > From: Anna-Maria Gleixner > > Install the callbacks via the state machine and let the core invoke > the callbacks on the already online CPUs. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Anna-Maria Gleixner > Signed-off-by: Sebastian Andrzej Siewior > --- > arch/arm64/kernel/cpuinfo.c | 37 +++++++++---------------------------- > 1 file changed, 9 insertions(+), 28 deletions(-) > > diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c > index 19aad7041e14..7b7be71e87bf 100644 > --- a/arch/arm64/kernel/cpuinfo.c > +++ b/arch/arm64/kernel/cpuinfo.c > @@ -227,7 +227,7 @@ static struct attribute_group cpuregs_attr_group = { ... > + ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "arm64/cpuinfo:online", > + cpuid_cpu_online, cpuid_cpu_offline); > + if (ret < 0) { > + pr_err("cpuinfo: failed to register hotplug callbacks.\n"); > + return ret; > + } > return 0; > } Reviewed-by: Suzuki K Poulose