From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Stefan Haberland <sth@linux.ibm.com>,
axboe@kernel.dk, hoeppner@linux.ibm.com,
linux-s390@vger.kernel.org, heiko.carstens@de.ibm.com,
gor@linux.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] s390/dasd: remove ioctl_by_bdev calls
Date: Wed, 7 Oct 2020 12:44:55 +0200 [thread overview]
Message-ID: <ca1bad1e-6d4b-7e86-4a98-b9ba12e2bef2@de.ibm.com> (raw)
In-Reply-To: <20201007103936.GA24327@lst.de>
On 07.10.20 12:39, Christoph Hellwig wrote:
> On Wed, Oct 07, 2020 at 11:34:17AM +0200, Christian Borntraeger wrote:
>>
>> On 19.05.20 16:22, Stefan Haberland wrote:
>>> The IBM partition parser requires device type specific information only
>>> available to the DASD driver to correctly register partitions. The
>>> current approach of using ioctl_by_bdev with a fake user space pointer
>>> is discouraged.
>>>
>>> Fix this by replacing IOCTL calls with direct in-kernel function calls.
>>>
>>> Suggested-by: Christoph Hellwig <hch@lst.de>
>>> Signed-off-by: Stefan Haberland <sth@linux.ibm.com>
>>> Reviewed-by: Jan Hoeppner <hoeppner@linux.ibm.com>
>>> Reviewed-by: Peter Oberparleiter <oberpar@linux.ibm.com>
>>
>> FWIW, this broken the ibm-partition code for virtio-blk, when CONFIG_DASD=m.
>
> What are the symptoms?
During boot I normally have
[ 0.930231] virtio_blk virtio1: [vda] 5409180 4096-byte logical blocks (22.2 GB/20.6 GiB)
[ 0.930233] vda: detected capacity change from 0 to 22156001280
[ 0.932806] vda:VOL1/ 0X3333: vda1 vda2 vda3
With this change, the last line is no longer there (if CONFIG_DASD=m) and this also
reflects itself in /proc/partitions. The partitions are no longer detected.
next prev parent reply other threads:[~2020-10-07 10:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 14:22 [PATCH v4 0/2] s390/dasd: remove ioctl_by_bdev from DASD driver Stefan Haberland
2020-05-19 14:22 ` [PATCH v4 1/2] dasd: refactor dasd_ioctl_information Stefan Haberland
2020-05-19 14:22 ` [PATCH v4 2/2] s390/dasd: remove ioctl_by_bdev calls Stefan Haberland
2020-05-19 14:29 ` Christoph Hellwig
2020-10-07 9:34 ` Christian Borntraeger
2020-10-07 10:39 ` Christoph Hellwig
2020-10-07 10:44 ` Christian Borntraeger [this message]
2020-10-07 11:09 ` Stefan Haberland
2020-10-07 12:00 ` Christoph Hellwig
2020-10-07 12:09 ` Christian Borntraeger
2020-10-07 12:14 ` Christoph Hellwig
2020-10-07 12:23 ` Christian Borntraeger
2020-05-19 14:33 ` [PATCH 3/2] block: remove ioctl_by_bdev Christoph Hellwig
2020-05-19 19:03 ` Al Viro
2020-05-19 19:29 ` Christoph Hellwig
2020-05-21 14:22 ` [PATCH v4 0/2] s390/dasd: remove ioctl_by_bdev from DASD driver Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca1bad1e-6d4b-7e86-4a98-b9ba12e2bef2@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=axboe@kernel.dk \
--cc=gor@linux.ibm.com \
--cc=hch@lst.de \
--cc=heiko.carstens@de.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sth@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).