From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936484AbcJ0NvJ (ORCPT ); Thu, 27 Oct 2016 09:51:09 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:43097 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936391AbcJ0NvF (ORCPT ); Thu, 27 Oct 2016 09:51:05 -0400 Subject: Re: [PATCH v3] ARM: davinci: da8xx: Fix some redefined symbol warnings To: Alexandre Bailon , , References: <1477485542-10555-1-git-send-email-abailon@baylibre.com> <1477485542-10555-2-git-send-email-abailon@baylibre.com> <7026f012-ffce-cc28-85be-9a5cd26de60f@ti.com> CC: , From: Sekhar Nori Message-ID: Date: Thu, 27 Oct 2016 17:24:53 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <7026f012-ffce-cc28-85be-9a5cd26de60f@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 27 October 2016 05:13 PM, Sekhar Nori wrote: > On Wednesday 26 October 2016 06:09 PM, Alexandre Bailon wrote: >> Some macro for DA8xx CFGCHIP are defined in usb-davinci.h, >> but da8xx-cfgchip.h intend to replace them. >> The usb-da8xx.c is using both headers, causing redefined symbol warnings. > > Looks like this is not true for v4.9-rc2 and so I don't see any warnings Ah, just noticed that _this_ is the patch that introduces da8xx-cfgchip.h into usb-da8xx.c. So this is the patch that introduces the warnings (and fixes them). I can queue this for v4.10 (with Greg's ack) if you change the description to make it about cleaning up duplicated defines between da8xx-cfgchip.h and usb-davinci.h and not talk about "redefined symbol warnings". Also, when adding a header file, can you please keep it sorted in alphabetical order. Thanks, Sekhar