From: "Kuppuswamy, Sathyanarayanan" <sathyanarayanan.kuppuswamy@linux.intel.com> To: Sean Christopherson <seanjc@google.com> Cc: Dave Hansen <dave.hansen@intel.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, Peter Zijlstra <peterz@infradead.org>, Andy Lutomirski <luto@kernel.org>, Peter H Anvin <hpa@zytor.com>, Tony Luck <tony.luck@intel.com>, Dan Williams <dan.j.williams@intel.com>, Andi Kleen <ak@linux.intel.com>, Kirill Shutemov <kirill.shutemov@linux.intel.com>, Kuppuswamy Sathyanarayanan <knsathya@kernel.org>, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 04/12] x86/tdx: Add protected guest support for TDX guest Date: Wed, 4 Aug 2021 16:00:18 -0700 [thread overview] Message-ID: <ca4aa25c-7d88-9812-4852-ced3274493a8@linux.intel.com> (raw) In-Reply-To: <YQsX54MPVYFuLmFr@google.com> On 8/4/21 3:42 PM, Sean Christopherson wrote: > What other possible use case is there for invoking tdx_prot_guest_has() beyond > running as a TDX guest? If it were e.g. intel_prot_guest_has() then I would at > least understand the code, if not agree with the sub-optimal approach, but as is > it makes no sense. Yes. I think his original intention is to implement intel_prot_guest_has() in arch/x86/kernel/cpu/intel.c and then call tdx_prot_guest_has() from it. But since we have no other use cases, we have called tdx_prot_*() directly here. Boris, how do you want to proceed? Do you want me to implement intel_prot_guest_has() or change comparison log to TDX specific? > > Given amd_prot_guest_has(), my guess is Boris intended intel_prot_guest_has()... -- Sathyanarayanan Kuppuswamy Linux Kernel Developer
next prev parent reply other threads:[~2021-08-04 23:00 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-04 18:13 [PATCH v5 00/12] Add TDX Guest Support (Initial support) Kuppuswamy Sathyanarayanan 2021-08-04 18:13 ` [PATCH v5 01/12] x86/paravirt: Move halt paravirt calls under CONFIG_PARAVIRT Kuppuswamy Sathyanarayanan 2021-08-12 7:18 ` Borislav Petkov 2021-08-12 17:17 ` Kuppuswamy, Sathyanarayanan 2021-08-17 12:50 ` Juergen Gross 2021-08-17 13:16 ` Kuppuswamy, Sathyanarayanan 2021-08-17 13:28 ` Juergen Gross 2021-08-17 13:39 ` Kuppuswamy, Sathyanarayanan 2021-08-17 13:47 ` Juergen Gross 2021-08-17 13:50 ` Kuppuswamy, Sathyanarayanan 2021-08-04 18:13 ` [PATCH v5 02/12] x86/tdx: Introduce INTEL_TDX_GUEST config option Kuppuswamy Sathyanarayanan 2021-08-04 18:13 ` [PATCH v5 03/12] x86/cpufeatures: Add TDX Guest CPU feature Kuppuswamy Sathyanarayanan 2021-08-12 7:39 ` Borislav Petkov 2021-08-04 18:13 ` [PATCH v5 04/12] x86/tdx: Add protected guest support for TDX guest Kuppuswamy Sathyanarayanan 2021-08-04 21:59 ` Sean Christopherson 2021-08-04 22:03 ` Dave Hansen 2021-08-04 22:26 ` Kuppuswamy, Sathyanarayanan 2021-08-04 22:42 ` Sean Christopherson 2021-08-04 23:00 ` Kuppuswamy, Sathyanarayanan [this message] 2021-08-12 7:53 ` Borislav Petkov 2021-08-12 17:18 ` Kuppuswamy, Sathyanarayanan 2021-08-20 14:28 ` Borislav Petkov 2021-08-20 16:42 ` Kuppuswamy, Sathyanarayanan 2021-08-20 16:59 ` Borislav Petkov 2021-08-20 17:11 ` Kuppuswamy, Sathyanarayanan 2021-08-04 18:13 ` [PATCH v5 05/12] x86/tdx: Add __tdx_module_call() and __tdx_hypercall() helper functions Kuppuswamy Sathyanarayanan 2021-08-20 15:16 ` Borislav Petkov 2021-08-04 18:13 ` [PATCH v5 06/12] x86/tdx: Get TD execution environment information via TDINFO Kuppuswamy Sathyanarayanan 2021-08-04 22:38 ` Sean Christopherson 2021-08-20 17:13 ` Borislav Petkov 2021-08-20 17:31 ` Kuppuswamy, Sathyanarayanan 2021-08-20 17:35 ` Borislav Petkov 2021-08-20 18:29 ` Kuppuswamy, Sathyanarayanan 2021-08-20 18:58 ` Andi Kleen 2021-08-20 19:01 ` Kuppuswamy, Sathyanarayanan 2021-08-04 18:13 ` [PATCH v5 07/12] x86/traps: Add #VE support for TDX guest Kuppuswamy Sathyanarayanan 2021-08-24 10:17 ` Borislav Petkov 2021-08-24 17:32 ` Kuppuswamy, Sathyanarayanan 2021-08-24 17:36 ` Dave Hansen 2021-08-24 17:46 ` Borislav Petkov 2021-09-02 15:24 ` Kuppuswamy, Sathyanarayanan 2021-09-03 10:17 ` Borislav Petkov 2021-08-04 18:13 ` [PATCH v5 08/12] x86/tdx: Add HLT " Kuppuswamy Sathyanarayanan 2021-08-24 16:10 ` Borislav Petkov 2021-08-24 17:06 ` Sean Christopherson 2021-08-24 17:25 ` Andi Kleen 2021-08-24 17:27 ` Borislav Petkov 2021-08-24 17:47 ` Sean Christopherson 2021-08-24 17:50 ` Borislav Petkov 2021-08-31 20:49 ` Kuppuswamy, Sathyanarayanan 2021-09-01 7:42 ` Borislav Petkov 2021-08-24 18:18 ` Kuppuswamy, Sathyanarayanan 2021-08-24 18:28 ` Andi Kleen 2021-08-24 17:35 ` Kuppuswamy, Sathyanarayanan 2021-08-24 17:48 ` Borislav Petkov 2021-08-04 18:13 ` [PATCH v5 09/12] x86/tdx: Wire up KVM hypercalls Kuppuswamy Sathyanarayanan 2021-08-24 16:34 ` Borislav Petkov 2021-08-24 18:11 ` Kuppuswamy, Sathyanarayanan 2021-08-24 18:29 ` Borislav Petkov 2021-08-24 19:11 ` Kuppuswamy, Sathyanarayanan 2021-08-24 19:39 ` Borislav Petkov 2021-08-04 18:13 ` [PATCH v5 10/12] x86/tdx: Add MSR support for TDX guest Kuppuswamy Sathyanarayanan 2021-08-24 16:55 ` Borislav Petkov 2021-08-24 18:12 ` Kuppuswamy, Sathyanarayanan 2021-08-04 18:13 ` [PATCH v5 11/12] x86/tdx: Don't write CSTAR MSR on Intel Kuppuswamy Sathyanarayanan 2021-08-04 18:31 ` Sean Christopherson 2021-08-04 21:03 ` Kuppuswamy, Sathyanarayanan 2021-08-04 21:44 ` Sean Christopherson 2021-08-04 21:48 ` Dave Hansen 2021-08-04 22:23 ` Kuppuswamy, Sathyanarayanan 2021-08-04 18:13 ` [PATCH v5 12/12] x86/tdx: Handle CPUID via #VE Kuppuswamy Sathyanarayanan 2021-08-24 17:48 ` Borislav Petkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ca4aa25c-7d88-9812-4852-ced3274493a8@linux.intel.com \ --to=sathyanarayanan.kuppuswamy@linux.intel.com \ --cc=ak@linux.intel.com \ --cc=bp@alien8.de \ --cc=dan.j.williams@intel.com \ --cc=dave.hansen@intel.com \ --cc=hpa@zytor.com \ --cc=kirill.shutemov@linux.intel.com \ --cc=knsathya@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --cc=seanjc@google.com \ --cc=tglx@linutronix.de \ --cc=tony.luck@intel.com \ --cc=x86@kernel.org \ --subject='Re: [PATCH v5 04/12] x86/tdx: Add protected guest support for TDX guest' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).