From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: "Fried, Ramon" <ramon.fried@linux.intel.com>,
<linus.walleij@linaro.org>, <bgolaszewski@baylibre.com>,
<linux-gpio@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <vladimir.kondratiev@linux.intel.com>
Subject: Re: RFC: gpio: mmio: add support for 3 direction regs
Date: Thu, 3 Jan 2019 10:07:11 +0200 [thread overview]
Message-ID: <ca7c1b99-4166-652b-aa53-8272aa66eb73@mentor.com> (raw)
In-Reply-To: <32edfd70-95dc-26a1-2ea6-143344cb2384@linux.intel.com>
Hi Ramon,
On 01/03/2019 09:36 AM, Fried, Ramon wrote:
> Hi.
>
> I'm working on a driver for STA2X11 GPIO controller who seems to fit
> best to the generic mmio driver,
I hope you have seen the existing driver drivers/gpio/gpio-sta2x11.c
> the only problem I have is with the dir register case. The STA2X11
> has 3 registers for dir, one for data, one for set and one for
> clear. The generic-mmio driver has support for this fashion for the
> dat & set & clear registers but not for dirout/dirin registers.
>
> I wonder if support for this is generic enough to deserve a patch, if
> so I'm willing to quickly add this support, if not, adding a flag
> such as below, will allow partly using the generic mmio driver only
> for set/get and the direction can be handled outside the driver.
>
If gpio-mmio fits well, then it might be simpler to set a flag
BGPIOF_UNREADABLE_REG_DIR, then call bgpio_init() and then overwrite
.direction_input, .direction_output and .get_direction callbacks,
as a reference you can take a look at gpio-74xx-mmio.c
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2019-01-03 8:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 7:36 RFC: gpio: mmio: add support for 3 direction regs Fried, Ramon
2019-01-03 8:07 ` Vladimir Zapolskiy [this message]
2019-01-03 8:51 ` Fried, Ramon
2019-01-03 8:59 ` Vladimir Zapolskiy
2019-01-03 9:30 ` Fried, Ramon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca7c1b99-4166-652b-aa53-8272aa66eb73@mentor.com \
--to=vladimir_zapolskiy@mentor.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ramon.fried@linux.intel.com \
--cc=vladimir.kondratiev@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).