From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB192ECDFB3 for ; Tue, 17 Jul 2018 08:30:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4932C20C0B for ; Tue, 17 Jul 2018 08:30:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="V+XnH+zV"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="hAjgHdWw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4932C20C0B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729060AbeGQJCJ (ORCPT ); Tue, 17 Jul 2018 05:02:09 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52808 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728024AbeGQJCI (ORCPT ); Tue, 17 Jul 2018 05:02:08 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B41C860B7F; Tue, 17 Jul 2018 08:30:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1531816238; bh=x9Bt6mETE0lSDv3O6sBnD/A2P9/1BYs479Of81kPsjY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=V+XnH+zV5siDAihm8TOmCZa0wyEyvYR2hiOjMrKyMv1G8Z/3XWkEYR8PBefZHaITO o94VlhxWdqYCk+roSQHg2a6SU2++Y5A4E578jUhkjdANNtR4PXPgJG+4JKNaxNxcsb egPvFEG2WfHC31V/NvJ3KltN0+romF9cTvSxWmkY= Received: from [10.79.40.153] (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: vivek.gautam@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 95C796060A; Tue, 17 Jul 2018 08:30:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1531816237; bh=x9Bt6mETE0lSDv3O6sBnD/A2P9/1BYs479Of81kPsjY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=hAjgHdWw9/bQlyNpmBrhHhNT+WBIN/4sWW45P/ae5C+gQ5+5N6gl5tUhT9LEbbpRu eiqXad2b6jR7TaXBIsh/0Osb8yQKEZXAEUDYgnJra3zYzua0soh44Zx9sU3q+tQjUk 4qbQsF64/Xpnb1zK9Y8qzZxUHmkwDZgNRD+NWDH0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 95C796060A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org Subject: Re: [PATCH v12 3/4] iommu/arm-smmu: Add the device_link between masters and smmu To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , "list@263.net:IOMMU DRIVERS" , Joerg Roedel , robh+dt , Mark Rutland , Robin Murphy , Will Deacon , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , Alex Williamson , Rob Clark , Linux PM , freedreno , Stephen Boyd , Tomasz Figa , Sricharan R , Marek Szyprowski , Archit Taneja , linux-arm-msm , Jordan Crouse , Lukas Wunner References: <20180708173413.1965-1-vivek.gautam@codeaurora.org> <20180708173413.1965-4-vivek.gautam@codeaurora.org> <5179668.PHK6S3sxLu@aspire.rjw.lan> <741cc78b-59a7-5289-e42f-1511ebedb15d@codeaurora.org> <93d16301-4bef-203f-24de-4d010de84b22@codeaurora.org> From: Vivek Gautam Message-ID: Date: Tue, 17 Jul 2018 14:00:29 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/17/2018 1:16 PM, Rafael J. Wysocki wrote: > On Mon, Jul 16, 2018 at 1:46 PM, Vivek Gautam > wrote: >> >> On 7/16/2018 2:25 PM, Rafael J. Wysocki wrote: >>> On Thu, Jul 12, 2018 at 2:41 PM, Vivek Gautam >>> wrote: >>>> Hi Rafael, >>>> >>>> >>>> On Wed, Jul 11, 2018 at 4:06 PM, Vivek Gautam >>>> wrote: >>>>> Hi Rafael, >>>>> >>>>> >>>>> >>>>> On 7/11/2018 3:23 PM, Rafael J. Wysocki wrote: >>>>>> On Sunday, July 8, 2018 7:34:12 PM CEST Vivek Gautam wrote: >>>>>>> From: Sricharan R >>>>>>> >>>>>>> Finally add the device link between the master device and >>>>>>> smmu, so that the smmu gets runtime enabled/disabled only when the >>>>>>> master needs it. This is done from add_device callback which gets >>>>>>> called once when the master is added to the smmu. >>>>>>> >>>>>>> Signed-off-by: Sricharan R >>>>>>> Signed-off-by: Vivek Gautam >>>>>>> Reviewed-by: Tomasz Figa >>>>>>> Cc: Rafael J. Wysocki >>>>>>> Cc: Lukas Wunner >>>>>>> --- >>>>>>> >>>>>>> - Change since v11 >>>>>>> * Replaced DL_FLAG_AUTOREMOVE flag with >>>>>>> DL_FLAG_AUTOREMOVE_SUPPLIER. >>>>>>> >>>>>>> drivers/iommu/arm-smmu.c | 12 ++++++++++++ >>>>>>> 1 file changed, 12 insertions(+) >>>>>>> >>>>>>> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c >>>>>>> index 09265e206e2d..916cde4954d2 100644 >>>>>>> --- a/drivers/iommu/arm-smmu.c >>>>>>> +++ b/drivers/iommu/arm-smmu.c >>>>>>> @@ -1461,8 +1461,20 @@ static int arm_smmu_add_device(struct device >>>>>>> *dev) >>>>>>> iommu_device_link(&smmu->iommu, dev); >>>>>>> + if (pm_runtime_enabled(smmu->dev) && >>>>>> Why does the creation of the link depend on whether or not runtime PM >>>>>> is enabled for the MMU device? >>>>> >>>>> The main purpose of this device link is to handle the runtime PM >>>>> synchronization >>>>> between the supplier (iommu) and consumer (client devices, such as >>>>> GPU/display). >>>>> Moreover, the runtime pm is conditionally enabled for smmu devices that >>>>> support >>>>> such [1]. >>>> Is there something you would like me to modify in this patch? >>> Not really, as long as you are sure that it is correct. :-) >>> >>> You need to remember, however, that if you add system-wide PM >>> callbacks to the driver, the ordering between them and the client >>> device callbacks during system-wide suspend matters as well. Don't >>> you need the link the ensure the correct system-wide suspend ordering >>> too? >> >> The fact that currently we handle clocks only through runtime pm callbacks, >> would it be better to call runtime pm put/get in system-wide PM callbacks. >> This would be same as i mentioned in the other thread. > Well, my point is that there's no reason for system-wide suspend to > depend directly on runtime PM (which can be effectively disabled by > user space as mentioned for multiple times in this thread). > > It simply is not efficient to let the clock run while the system as a > whole is sleeping (even if power/control has been set to "on" for this > particular device) and it should not be too hard to prevent that from > happening. You may need an additional flag in the driver for that or > similar, but it definitely should be doable. Right, I will modify the things are required. Thanks again for pointing this out. Best regards Vivek > > Now, that's my advice and I'm not the maintainer of that code, so it > is your call (as long as the maintainer agrees with it). > > Thanks, > Rafael