* [PATCH] locking/test-ww_mutex: use swap()
@ 2021-10-20 9:15 cgel.zte
2021-10-20 13:59 ` Waiman Long
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2021-10-20 9:15 UTC (permalink / raw)
To: longman
Cc: mingo, will, boqun.feng, linux-kernel, Changcheng Deng, Zeal Robot
From: Changcheng Deng <deng.changcheng@zte.com.cn>
Use swap() in order to make code cleaner. Issue found by coccinelle.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
kernel/locking/test-ww_mutex.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/kernel/locking/test-ww_mutex.c b/kernel/locking/test-ww_mutex.c
index 353004155d65..fa021b8a9edc 100644
--- a/kernel/locking/test-ww_mutex.c
+++ b/kernel/locking/test-ww_mutex.c
@@ -389,7 +389,7 @@ struct stress {
static int *get_random_order(int count)
{
int *order;
- int n, r, tmp;
+ int n, r;
order = kmalloc_array(count, sizeof(*order), GFP_KERNEL);
if (!order)
@@ -400,11 +400,8 @@ static int *get_random_order(int count)
for (n = count - 1; n > 1; n--) {
r = get_random_int() % (n + 1);
- if (r != n) {
- tmp = order[n];
- order[n] = order[r];
- order[r] = tmp;
- }
+ if (r != n)
+ swap(order[n], order[r]);
}
return order;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] locking/test-ww_mutex: use swap()
2021-10-20 9:15 [PATCH] locking/test-ww_mutex: use swap() cgel.zte
@ 2021-10-20 13:59 ` Waiman Long
0 siblings, 0 replies; 2+ messages in thread
From: Waiman Long @ 2021-10-20 13:59 UTC (permalink / raw)
To: cgel.zte
Cc: mingo, will, boqun.feng, linux-kernel, Changcheng Deng, Zeal Robot
On 10/20/21 5:15 AM, cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> Use swap() in order to make code cleaner. Issue found by coccinelle.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
> ---
> kernel/locking/test-ww_mutex.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/locking/test-ww_mutex.c b/kernel/locking/test-ww_mutex.c
> index 353004155d65..fa021b8a9edc 100644
> --- a/kernel/locking/test-ww_mutex.c
> +++ b/kernel/locking/test-ww_mutex.c
> @@ -389,7 +389,7 @@ struct stress {
> static int *get_random_order(int count)
> {
> int *order;
> - int n, r, tmp;
> + int n, r;
>
> order = kmalloc_array(count, sizeof(*order), GFP_KERNEL);
> if (!order)
> @@ -400,11 +400,8 @@ static int *get_random_order(int count)
>
> for (n = count - 1; n > 1; n--) {
> r = get_random_int() % (n + 1);
> - if (r != n) {
> - tmp = order[n];
> - order[n] = order[r];
> - order[r] = tmp;
> - }
> + if (r != n)
> + swap(order[n], order[r]);
> }
>
> return order;
Acked-by: Waiman Long <longman@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-20 14:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-20 9:15 [PATCH] locking/test-ww_mutex: use swap() cgel.zte
2021-10-20 13:59 ` Waiman Long
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).