From: Jane Chu <jane.chu@oracle.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH v3 1/2] mm/memory-failure.c clean up around tk pre-allocation
Date: Tue, 6 Aug 2019 10:26:49 -0700 [thread overview]
Message-ID: <cad86094-c9ce-7bc1-5342-2bb03b512e71@oracle.com> (raw)
In-Reply-To: <20190801090651.GC31767@hori.linux.bs1.fc.nec.co.jp>
Hi, Naoya,
Thanks a lot! v4 on the way. :)
-jane
On 8/1/2019 2:06 AM, Naoya Horiguchi wrote:
> On Thu, Jul 25, 2019 at 04:01:40PM -0600, Jane Chu wrote:
>> add_to_kill() expects the first 'tk' to be pre-allocated, it makes
>> subsequent allocations on need basis, this makes the code a bit
>> difficult to read. Move all the allocation internal to add_to_kill()
>> and drop the **tk argument.
>>
>> Signed-off-by: Jane Chu <jane.chu@oracle.com>
>
> Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>
> # somehow I sent 2 acks to 2/2, sorry about the noise.
>
next prev parent reply other threads:[~2019-08-06 17:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 22:01 [PATCH v3 0/2] mm/memory-failure: Poison read receives SIGKILL instead of SIGBUS issue Jane Chu
2019-07-25 22:01 ` [PATCH v3 1/2] mm/memory-failure.c clean up around tk pre-allocation Jane Chu
2019-08-01 9:06 ` Naoya Horiguchi
2019-08-06 17:26 ` Jane Chu [this message]
2019-07-25 22:01 ` [PATCH v3 2/2] mm/memory-failure: Poison read receives SIGKILL instead of SIGBUS if mmaped more than once Jane Chu
2019-08-01 8:17 ` Naoya Horiguchi
2019-08-01 8:18 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cad86094-c9ce-7bc1-5342-2bb03b512e71@oracle.com \
--to=jane.chu@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).