From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DE4CC4360C for ; Fri, 27 Sep 2019 01:00:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D41D620835 for ; Fri, 27 Sep 2019 01:00:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727468AbfI0BAu (ORCPT ); Thu, 26 Sep 2019 21:00:50 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:33484 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725808AbfI0BAt (ORCPT ); Thu, 26 Sep 2019 21:00:49 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id B1B241319645B0196D57; Fri, 27 Sep 2019 09:00:47 +0800 (CST) Received: from [127.0.0.1] (10.177.251.225) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.439.0; Fri, 27 Sep 2019 09:00:44 +0800 Subject: Re: [PATCH] async: Let kfree() out of the critical area of the lock To: Bart Van Assche , , , "tglx@linutronix.de" , "Alexander Duyck" , , "gregkh@linuxfoundation.org" , David Sterba , "linux-kernel@vger.kernel.org" References: <216356b1-38c1-8477-c4e8-03f497dd6ac8@huawei.com> <20190926110648.GM2751@suse.cz> From: Yunfeng Ye Message-ID: Date: Fri, 27 Sep 2019 09:00:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.251.225] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/9/26 23:18, Bart Van Assche wrote: > On 9/26/19 4:06 AM, David Sterba wrote: >> On Thu, Sep 26, 2019 at 03:58:36PM +0800, Yunfeng Ye wrote: >>> The async_lock is big global lock, I think it's good to put kfree() outside >>> to keep the critical area as short as possible. >> >> Agreed, kfree is not always cheap. We had patches in btrfs moving kfree >> out of critical section(s) after causing softlockups due to increased lock >> contention. > > The above would be a great addition for the commit description. Anyway: > ok, I will update the description, thanks. > Reviewed-by: Bart Van Assche > > . >