From: Hans Verkuil <hverkuil@xs4all.nl>
To: yuji2.ishikawa@toshiba.co.jp, laurent.pinchart@ideasonboard.com,
mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
nobuhiro1.iwamatsu@toshiba.co.jp
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 5/5] MAINTAINERS: Add entries for Toshiba Visconti Video Input Interface
Date: Wed, 6 Dec 2023 11:59:30 +0100 [thread overview]
Message-ID: <cae19173-1b36-4300-b770-782a7b7c2200@xs4all.nl> (raw)
In-Reply-To: <TYAPR01MB62015CB80317567D6F9C4A5E92BDA@TYAPR01MB6201.jpnprd01.prod.outlook.com>
On 27/11/2023 01:38, yuji2.ishikawa@toshiba.co.jp wrote:
> Hello Hans,
> Thank you for the review.
>
>> -----Original Message-----
>> From: Hans Verkuil <hverkuil@xs4all.nl>
>> Sent: Tuesday, November 14, 2023 5:41 PM
>> To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開)
>> <yuji2.ishikawa@toshiba.co.jp>; Laurent Pinchart
>> <laurent.pinchart@ideasonboard.com>; Mauro Carvalho Chehab
>> <mchehab@kernel.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof
>> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
>> <conor+dt@kernel.org>; iwamatsu nobuhiro(岩松 信洋 ○DITC□DIT○
>> OST) <nobuhiro1.iwamatsu@toshiba.co.jp>
>> Cc: linux-media@vger.kernel.org; devicetree@vger.kernel.org;
>> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH v9 5/5] MAINTAINERS: Add entries for Toshiba Visconti
>> Video Input Interface
>>
>> On 12/10/2023 09:13, Yuji Ishikawa wrote:
>>> Added entries for visconti Video Input Interface driver, including;
>>> * device tree bindings
>>> * source files
>>> * documentation files
>>>
>>> Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>
>>> ---
>>> Changelog v2:
>>> - no change
>>>
>>> Changelog v3:
>>> - added entry for driver API documentation
>>>
>>> Changelog v4:
>>> - added entry for header file
>>>
>>> Changelog v5:
>>> - no change
>>>
>>> Changelog v6:
>>> - update path to VIIF driver source files
>>>
>>> Changelog v7:
>>> - no change
>>>
>>> Changelog v8:
>>> - rename bindings description file
>>>
>>> Changelog v9:
>>> - no change
>>>
>>> MAINTAINERS | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS index
>>> eaa1a28a9d54..6035f711b3fb 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -2902,17 +2902,21 @@ F:
>> Documentation/devicetree/bindings/arm/toshiba.yaml
>>> F:
>> Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pipllct.y
>> aml
>>> F:
>> Documentation/devicetree/bindings/clock/toshiba,tmpv770x-pismu.y
>> aml
>>> F: Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml
>>> +F:
>> Documentation/devicetree/bindings/media/toshiba,visconti5-viif.yam
>> l
>>> F:
>> Documentation/devicetree/bindings/net/toshiba,visconti-dwmac.ya
>> ml
>>> F: Documentation/devicetree/bindings/pci/toshiba,visconti-pcie.yaml
>>> F:
>> Documentation/devicetree/bindings/pinctrl/toshiba,visconti-pinctrl.y
>> aml
>>> F:
>> Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.
>> yaml
>>> +F: Documentation/driver-api/media/drivers/visconti-viif.rst
>>> F: arch/arm64/boot/dts/toshiba/
>>> F: drivers/clk/visconti/
>>> F: drivers/gpio/gpio-visconti.c
>>> +F: drivers/media/platform/toshiba/visconti/
>>> F: drivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c
>>> F: drivers/pci/controller/dwc/pcie-visconti.c
>>> F: drivers/pinctrl/visconti/
>>> F: drivers/watchdog/visconti_wdt.c
>>> +F: include/uapi/linux/visconti_viif.h
>>> N: visconti
>>
>> This is a bit odd: it adds the driver to an existing entry, but you do not add
>> yourself as maintainer. Typically a large driver like this one will have its own
>> entry.
>>
>> At minimum I need an Acked-by from Nobuhiro Iwamatsu for this change. But I
>> think it might be better to make a separate entry for this driver. Up to you,
>> though.
>
> I'll make a separate entry for Visconti VIIF driver.
> I talked it over with Iwamatsu-san and he agreed.
> I need Acked-by tag from him at v10 patch submission; is it a correct understanding?
Yes, that's correct.
Regards,
Hans
>
>>
>> Regards,
>>
>> Hans
>>
>>>
>>> ARM/UNIPHIER ARCHITECTURE
>
> Regards,
> Yuji
prev parent reply other threads:[~2023-12-06 11:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 7:13 [PATCH v9 0/5] Add Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2023-10-12 7:13 ` [PATCH v9 1/5] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface Yuji Ishikawa
2023-10-12 19:24 ` Krzysztof Kozlowski
2023-10-12 7:13 ` [PATCH v9 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2023-10-12 7:13 ` [PATCH v9 3/5] media: platform: visconti: add V4L2 vendor specific control handlers Yuji Ishikawa
2023-11-14 9:02 ` Hans Verkuil
2023-11-14 9:10 ` Hans Verkuil
2023-11-14 9:53 ` Laurent Pinchart
2023-11-27 0:46 ` yuji2.ishikawa
2023-12-06 11:08 ` Hans Verkuil
2023-12-11 0:35 ` yuji2.ishikawa
2023-11-27 0:45 ` yuji2.ishikawa
2023-12-06 11:03 ` Hans Verkuil
2023-11-27 0:43 ` yuji2.ishikawa
2023-10-12 7:13 ` [PATCH v9 4/5] documentation: media: add documentation for Toshiba Visconti Video Input Interface driver Yuji Ishikawa
2023-11-14 8:49 ` Hans Verkuil
2023-11-27 0:39 ` yuji2.ishikawa
2023-11-22 11:40 ` Sakari Ailus
2023-12-04 4:32 ` yuji2.ishikawa
2024-02-02 6:49 ` Sakari Ailus
2024-04-22 6:45 ` yuji2.ishikawa
2023-10-12 7:13 ` [PATCH v9 5/5] MAINTAINERS: Add entries for Toshiba Visconti Video Input Interface Yuji Ishikawa
2023-11-14 8:40 ` Hans Verkuil
2023-11-27 0:38 ` yuji2.ishikawa
2023-12-06 10:59 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cae19173-1b36-4300-b770-782a7b7c2200@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=robh+dt@kernel.org \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).