From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05790C433FE for ; Thu, 21 Apr 2022 06:39:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384960AbiDUGmi (ORCPT ); Thu, 21 Apr 2022 02:42:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384922AbiDUGmX (ORCPT ); Thu, 21 Apr 2022 02:42:23 -0400 Received: from maillog.nuvoton.com (maillog.nuvoton.com [202.39.227.15]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 521F3E0A9; Wed, 20 Apr 2022 23:39:33 -0700 (PDT) Received: from NTHCCAS04.nuvoton.com (NTHCCAS04.nuvoton.com [10.1.8.29]) by maillog.nuvoton.com (Postfix) with ESMTP id 089D01C810D0; Thu, 21 Apr 2022 14:39:31 +0800 (CST) Received: from NTHCCAS04.nuvoton.com (10.1.8.29) by NTHCCAS04.nuvoton.com (10.1.8.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 21 Apr 2022 14:39:30 +0800 Received: from [172.19.1.47] (172.19.1.47) by NTHCCAS04.nuvoton.com (10.1.12.25) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Thu, 21 Apr 2022 14:39:30 +0800 Message-ID: Date: Thu, 21 Apr 2022 14:39:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v3 5/5] dt-bindings: arm: Add initial bindings for Nuvoton Platform Content-Language: en-US To: Krzysztof Kozlowski , , , , , CC: , , , , , , , References: <20220418082738.11301-1-ychuang3@nuvoton.com> <20220418082738.11301-6-ychuang3@nuvoton.com> From: Jacky Huang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/4/18 下午 08:11, Krzysztof Kozlowski wrote: > On 18/04/2022 10:27, Jacky Huang wrote: >> +properties: >> + $nodename: >> + const: '/' >> + compatible: >> + items: >> + - enum: >> + - nuvoton,ma35d1 >> + - nuvoton,ma35d1-evb >> + - nuvoton,ma35d1-iot >> + - nuvoton,ma35d1-som512 >> + - nuvoton,ma35d1-som1g > This does not match your DTS and does not look reasonable (SoC > compatible should not be part of this enum). Check some other board > bindings for examples. > > > Best regards, > Krzysztof I would like to modify it as follows: description: |   Boards with an ARMv8 based Nuvoton SoC shall have the following   properties. properties:   $nodename:     const: '/'   compatible:     oneOf:       - description: MA35D1 evaluation board         items:           - const: nuvoton,ma35d1-evb           - const: nuvoton,ma35d1       - description: MA35D1 IoT board         items:           - const: nuvoton,ma35d1-iot           - const: nuvoton,ma35d1       - description: MA35D1 SOM board with 512MB DDR         items:           - const: nuvoton,ma35d1-som512           - const: nuvoton,ma35d1       - description: MA35D1 SOM board with 1GB DDR         items:           - const: nuvoton,ma35d1-som1g           - const: nuvoton,ma35d1 additionalProperties: true Thank you very much. Jacky Huang