From: Ian Abbott <abbotti@mev.co.uk>
To: Xiaohui Zhang <xiaohuizhang@ruc.edu.cn>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] comedi: ni_usb6501: fix transfer-buffer overflows
Date: Tue, 7 Jun 2022 13:30:59 +0100 [thread overview]
Message-ID: <cafcc2b1-2b9b-4957-ee8a-9e260a7e2f5d@mev.co.uk> (raw)
In-Reply-To: <20220607111802.13311-1-xiaohuizhang@ruc.edu.cn>
On 07/06/2022 12:18, Xiaohui Zhang wrote:
> Similar to the handling of vmk80xx_alloc_usb_buffers in commit
> a23461c47482("comedi: vmk80xx: fix transfer-buffer overflows"),
> we thought a patch might be needed here as well.
>
> The driver uses endpoint-sized USB transfer buffers but up until
> recently had no sanity checks on the sizes.
>
> Signed-off-by: Xiaohui Zhang <xiaohuizhang@ruc.edu.cn>
> ---
> drivers/comedi/drivers/ni_usb6501.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/comedi/drivers/ni_usb6501.c b/drivers/comedi/drivers/ni_usb6501.c
> index 0dd9edf7bced..8303bfc305c5 100644
> --- a/drivers/comedi/drivers/ni_usb6501.c
> +++ b/drivers/comedi/drivers/ni_usb6501.c
> @@ -90,6 +90,7 @@
> #include <linux/comedi/comedi_usb.h>
>
> #define NI6501_TIMEOUT 1000
> +#define MIN_BUF_SIZE 64
>
> /* Port request packets */
> static const u8 READ_PORT_REQUEST[] = {0x00, 0x01, 0x00, 0x10,
> @@ -459,12 +460,12 @@ static int ni6501_alloc_usb_buffers(struct comedi_device *dev)
> struct ni6501_private *devpriv = dev->private;
> size_t size;
>
> - size = usb_endpoint_maxp(devpriv->ep_rx);
> + size = max(usb_endpoint_maxp(devpriv->ep_rx), MIN_BUF_SIZE);
> devpriv->usb_rx_buf = kzalloc(size, GFP_KERNEL);
> if (!devpriv->usb_rx_buf)
> return -ENOMEM;
>
> - size = usb_endpoint_maxp(devpriv->ep_tx);
> + size = max(usb_endpoint_maxp(devpriv->ep_tx), MIN_BUF_SIZE);
> devpriv->usb_tx_buf = kzalloc(size, GFP_KERNEL);
> if (!devpriv->usb_tx_buf)
> return -ENOMEM;
The code change looks OK but this patch should have been sent as a "v2"
patch and should have a brief description of the v2 changes after the
"---" line.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company )=-
-=( registered in England & Wales. Regd. number: 02862268. )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
next prev parent reply other threads:[~2022-06-07 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 11:18 [PATCH 1/1] comedi: ni_usb6501: fix transfer-buffer overflows Xiaohui Zhang
2022-06-07 12:30 ` Ian Abbott [this message]
2022-06-07 12:48 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2022-06-05 12:43 Xiaohui Zhang
2022-06-05 12:49 ` Greg Kroah-Hartman
2022-06-06 10:03 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cafcc2b1-2b9b-4957-ee8a-9e260a7e2f5d@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaohuizhang@ruc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).