From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE627C43217 for ; Tue, 5 Oct 2021 22:21:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D7EE60F11 for ; Tue, 5 Oct 2021 22:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236844AbhJEWW7 (ORCPT ); Tue, 5 Oct 2021 18:22:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236799AbhJEWW5 (ORCPT ); Tue, 5 Oct 2021 18:22:57 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFBE5C061755 for ; Tue, 5 Oct 2021 15:21:06 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id k3so644603qve.10 for ; Tue, 05 Oct 2021 15:21:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xHu5SUa0KvSYg3r+SFZDDB6DZ4/1EXbWcPW3NE3eBV8=; b=mGLTs7eKVP2Mm3xWUXlknMwhSa++0+cb4Px74ojuoliqTl/wkZCOKltUHsuZn6aCLV 1KSnuHn3IaxmCsEa4oDDE2pQkp/gOPVngmhjr7Daoc0vOP5qLR1b1owvq+OO2i3xbxBp g8YadytIdhE+bYkHtWf7paQIVUCwPLr+tJkdOVQnsU4otUosdnWEqS9aPTSe2Q1w/pU3 7wglGjGVFDU+o+TEZPRY9iHNXG1olifTlNPmHqVmttNlHt67pqaD3P1ug53dXGn1NTuP b5WLfVSa8GXDzHBTYqvWHKuX/LEKLYYtAPG3yv11JwC9fMz//jAcpKIsKJ6w8zcPaOU3 VnzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xHu5SUa0KvSYg3r+SFZDDB6DZ4/1EXbWcPW3NE3eBV8=; b=6TAp5NtLO78LRVjKmUmAafButPmY6RxR9WZZix5WuuYdIr6evBYAb3tLnai3NgrkZd N2F8LatLh7Z5CoGwbwCL5lgRduFx1YpQl4ThRyu4aeSKDCOeP+KYSG1cnbTpXKLQk9r2 pLgGU68V792qjrVYTVOQuejsaeUy5kzf5+M0yGgGewVlutOxJLxh3N+2kkdB7uFEKlia 4airWoYF054dmQ4sCmnAF9XSKJ4NpAP27gKOtUYKwVtWOKHDOSeIGgNnHlkNxSjniZJq XKucbV2eYQZe8JszXSvAZ9HauRwH+zEsN1HhyEQFhMKwdXLSdMokUNBaO/hexgTQjR2+ ozFw== X-Gm-Message-State: AOAM530ZCGeG8IIATPKO++ySTshRVfA1W+pltB1JoLvlMIQ7E2n8Mw4s AHfF25YAN/txmIHVTR68c8OgT7Fp3gWnOA== X-Google-Smtp-Source: ABdhPJzjAupsXhXHKMOteyIzCV8vgaSi6fiq3olLstOYpJpR1Adq/ORdBRgP1XeVPmd6GrIqkPv8hw== X-Received: by 2002:ad4:4664:: with SMTP id z4mr30100135qvv.16.1633472465623; Tue, 05 Oct 2021 15:21:05 -0700 (PDT) Received: from [192.168.1.93] (pool-71-163-245-5.washdc.fios.verizon.net. [71.163.245.5]) by smtp.gmail.com with ESMTPSA id b17sm11257816qte.97.2021.10.05.15.21.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Oct 2021 15:21:05 -0700 (PDT) Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: sdm845: mtp: Add vadc channels and thermal zones To: Bjorn Andersson Cc: Dmitry Baryshkov , Matthias Kaehlcke , Andy Gross , Zhang Rui , Daniel Lezcano , Amit Kucheria , Rob Herring , "open list:DRM DRIVER FOR MSM ADRENO GPU" , Linux PM , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20210923212311.2877048-1-bjorn.andersson@linaro.org> <20210923212311.2877048-5-bjorn.andersson@linaro.org> From: Thara Gopinath Message-ID: Date: Tue, 5 Oct 2021 18:21:04 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/5/21 5:52 PM, Bjorn Andersson wrote: > On Tue 05 Oct 13:30 PDT 2021, Thara Gopinath wrote: > >> >> >> On 10/4/21 4:56 PM, Dmitry Baryshkov wrote: >>> On Mon, 4 Oct 2021 at 23:13, Bjorn Andersson wrote: >>>> >>>> On Wed 29 Sep 11:40 PDT 2021, Matthias Kaehlcke wrote: >>>> >>>>> On Thu, Sep 23, 2021 at 02:23:11PM -0700, Bjorn Andersson wrote: >>>>>> Downstream defines four ADC channels related to thermal sensors external >>>>>> to the PM8998 and two channels for internal voltage measurements. >>>>>> >>>>>> Add these to the upstream SDM845 MTP, describe the thermal monitor >>>>>> channels and add thermal_zones for these. >>>>>> >>>>>> Signed-off-by: Bjorn Andersson >>>>>> --- >>>>>> >>>>>> In addition to the iio channels exposed by v1, Daniel wanted thermal_zones... >>>>>> >>>>>> Changes since v1: >>>>>> - Enable the pm8998_adc_tm and describe the ADC channels >>>>>> - Add thermal-zones for the new channels >>>>>> >>>>>> arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 128 ++++++++++++++++++++++++ >>>>>> 1 file changed, 128 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts >>>> [..] >>>>>> +&pm8998_adc { >>>>>> + adc-chan@4c { >>>>>> + reg = ; >>>>>> + label = "xo_therm"; >>>>>> + }; >>>>>> + >>>>>> + adc-chan@4d { >>>>>> + reg = ; >>>>>> + label = "msm_therm"; >>>>>> + }; >>>>>> + >>>>>> + adc-chan@4f { >>>>>> + reg = ; >>>>>> + label = "pa_therm1"; >>>>>> + }; >>>>>> + >>>>>> + adc-chan@51 { >>>>>> + reg = ; >>>>>> + label = "quiet_therm"; >>>>>> + }; >>>>>> + >>>>>> + adc-chan@83 { >>>>>> + reg = ; >>>>>> + label = "vph_pwr"; >>>>>> + }; >>>>>> + >>>>>> + adc-chan@85 { >>>>>> + reg = ; >>>>>> + label = "vcoin"; >>>>>> + }; >>>>>> +}; >>>>>> + >>>>>> +&pm8998_adc_tm { >>>>>> + status = "okay"; >>>>>> + >>>>>> + xo-thermistor@1 { >>>>>> + reg = <1>; >>>>>> + io-channels = <&pm8998_adc ADC5_XO_THERM_100K_PU>; >>>>>> + qcom,ratiometric; >>>>>> + qcom,hw-settle-time-us = <200>; >>>>>> + }; >>>>>> + >>>>>> + msm-thermistor@2 { >>>>>> + reg = <2>; >>>>>> + io-channels = <&pm8998_adc ADC5_AMUX_THM1_100K_PU>; >>>>>> + qcom,ratiometric; >>>>>> + qcom,hw-settle-time-us = <200>; >>>>>> + }; >>>>>> + >>>>>> + pa-thermistor@3 { >>>>>> + reg = <3>; >>>>>> + io-channels = <&pm8998_adc ADC5_AMUX_THM3_100K_PU>; >>>>>> + qcom,ratiometric; >>>>>> + qcom,hw-settle-time-us = <200>; >>>>>> + }; >>>>>> + >>>>>> + quiet-thermistor@4 { >>>>>> + reg = <4>; >>>>>> + io-channels = <&pm8998_adc ADC5_AMUX_THM5_100K_PU>; >>>>>> + qcom,ratiometric; >>>>>> + qcom,hw-settle-time-us = <200>; >>>>>> + }; >>>>>> +}; >>>>>> + >>>>> >>>>> The example in the 'qcom,spmi-adc-tm5' binding specifies 'qcom,ratiometric' >>>>> and 'qcom,hw-settle-time-us' for both the ADC and the thermal monitor, so do >>>>> several board files (e.g. sm8250-mtp.dts and qrb5165-rb5.dts). This apparent >>>>> redundancy bothered me earlier, it's not really clear to me whether it's >>>>> needed/recommended or not. Do you happen to have any insights on this? >>>> >>>> Hmm, you're right and I missed this in defining my channels. I've not >>>> looked at this detail, just got reasonable readings from my thermal >>>> zones and was happy about that. >>>> >>>> Dmitry, do you have any further insights why these properties are >>>> supposed to be duplicated between the adc channel and the thermal zones? >>> >>> Because both ADC channel and thermal zone registers should be >>> programmed accordingly. >>> >>> One not-so-perfect approach would be to use io-channels property to >>> locate the adc's adc-chan node and to parse it. However this way >>> thermal driver would have to know the exact structure of adc's device >>> tree nodes. >>> Another (even worse) solution would be to introduce qcom-specific API >>> to query these properties from the IIO channel. >>> >>> Selecting between these two options I decided to follow the downstream >>> path and just to duplicate these few properties. >> >> I know I am joining late to this party, since v3 is out. But before I send >> my acked-by, wanted to check/state a few things. >> To me, the not-so-perfect approach that you mention here is actually not so >> bad, considering the thermal sensor driver already is aware of internals of >> the adc device. The duplicating of node is kind of confusing. >> Also did you explore using one of _channel_write apis in iio framework to >> move all the writes into the adc device instead of thermal sensor driver ? >> > > To me the TM hardware block seems to just duplicate some parts of the > ADC block. Without understanding why the two would need to be configured > in sync, I don't think we should tie them together further. You are right. It is duplicating most of the ADC parts except for temperature read for which it calls into the adc device. And I don't see any interface from the ADC driver that can be used to do the configuration TM needs. Hence the question, have we ever explored this path ? > > In particular, I get the same readings with or without configuring the > ADC channels, does this perhaps imply that the TM configuration is used > to configure the ADC during it's reads (i.e. we don't need to define the > ADC channels after all), or is this just a coincidence? Maybe because of what we do in adc_tm5_init ? If needed, we should be able to duplicate the read in the TM as well and get rid of ADC channels , right ? I don't like this half configuration in TM and half in ADC device unless there is a reason behind this. > > There are other things in the PMIC, using the ADC seemingly without you > having to explicitly configure the ADC and there's definitely things > pointing to the ADC being "timeshared" between various users. > > Regards, > Bjorn > -- Warm Regards Thara (She/Her/Hers)