From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Mark Salyzyn <salyzyn@android.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH v4 01/21] nvmem: Mark nvmem_type_str array with __maybe_unused
Date: Wed, 28 Nov 2018 16:10:15 -0800 [thread overview]
Message-ID: <cb0e83e2f99aa066d40b3bb1c560486f0f278445.camel@perches.com> (raw)
In-Reply-To: <20181128190537.14074-2-andriy.shevchenko@linux.intel.com>
On Wed, 2018-11-28 at 21:05 +0200, Andy Shevchenko wrote:
> Since we put static variable to a header file it's copied to each module
> that includes the header. But not all of them are actually using it.
>
> Mark nvmem_type_str array with __maybe_unused to make a compiler happy:
>
> In file included from include/linux/rtc.h:18,
> from drivers/rtc/rtc-proc.c:15:
> include/linux/nvmem-provider.h:29:27: warning: ‘nvmem_type_str’ defined but not used [-Wunused-const-variable=]
> static const char * const nvmem_type_str[] = {
It would be better to move this definition into
the one file that seems to use it.
$ git grep -w nvmem_type_str
drivers/nvmem/core.c: return sprintf(buf, "%s\n", nvmem_type_str[nvmem->type])
include/linux/nvmem-provider.h:static const char * const nvmem_type_str[] = {
next prev parent reply other threads:[~2018-11-29 0:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 19:05 [PATCH v4 00/21] lib, rtc: Print rtc_time via %ptR[dt][r] Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 01/21] nvmem: Mark nvmem_type_str array with __maybe_unused Andy Shevchenko
2018-11-28 21:05 ` Alexandre Belloni
2018-11-29 0:10 ` Joe Perches [this message]
2018-11-28 19:05 ` [PATCH v4 02/21] lib/vsprintf: Print time and date in human readable format via %pt Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 03/21] rtc: Switch to use %ptR Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 04/21] rtc: at91rm9200: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 05/21] rtc: at91sam9: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 06/21] rtc: m41t80: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 07/21] rtc: m48t59: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 08/21] rtc: mcp795: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 09/21] rtc: pcf50633: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 10/21] rtc: pic32: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 11/21] rtc: pm8xxx: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 12/21] rtc: puv3: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 13/21] rtc: rk808: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 14/21] rtc: rx6110: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 15/21] rtc: rx8025: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 16/21] rtc: s3c: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 17/21] rtc: s5m: " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 18/21] rtc: tegra: " Andy Shevchenko
2018-11-28 19:48 ` Thierry Reding
2018-11-28 19:05 ` [PATCH v4 19/21] Input: hp_sdc_rtc - " Andy Shevchenko
2018-11-28 19:05 ` [PATCH v4 20/21] mk68/mac: " Andy Shevchenko
2018-11-29 9:08 ` Geert Uytterhoeven
2018-11-29 9:09 ` Geert Uytterhoeven
2018-11-28 19:05 ` [PATCH v4 21/21] PM: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb0e83e2f99aa066d40b3bb1c560486f0f278445.camel@perches.com \
--to=joe@perches.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=rasmus.villemoes@prevas.dk \
--cc=salyzyn@android.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).