From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E74CC433DB for ; Sun, 24 Jan 2021 15:14:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 138FF22B43 for ; Sun, 24 Jan 2021 15:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726462AbhAXPOV (ORCPT ); Sun, 24 Jan 2021 10:14:21 -0500 Received: from relay06.th.seeweb.it ([5.144.164.167]:60485 "EHLO relay06.th.seeweb.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726388AbhAXPNi (ORCPT ); Sun, 24 Jan 2021 10:13:38 -0500 Received: from [192.168.1.101] (abaf224.neoplus.adsl.tpnet.pl [83.6.169.224]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 0F0A93EB8B; Sun, 24 Jan 2021 16:12:36 +0100 (CET) Subject: Re: [PATCH 1/3] arm64: dts: qcom: Add device tree for BQ Aquaris X5 (Longcheer L8910) To: Jonathan Albrieux , linux-kernel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, stephan@gerhold.net, Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20210124135409.5473-1-jonathan.albrieux@gmail.com> <20210124135409.5473-2-jonathan.albrieux@gmail.com> From: Konrad Dybcio Message-ID: Date: Sun, 24 Jan 2021 16:12:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210124135409.5473-2-jonathan.albrieux@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The sorting on smd_rpm_regulators & msmgpio seems off.. unless it's the new thing to put it at the end? Also, did you forget the copyright header or is that on purpose? Otherwise, LGTM Konrad