From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E2FEC4321D for ; Thu, 23 Aug 2018 21:01:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4BE92150F for ; Thu, 23 Aug 2018 21:00:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4BE92150F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=i-love.sakura.ne.jp Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727735AbeHXAcZ (ORCPT ); Thu, 23 Aug 2018 20:32:25 -0400 Received: from www262.sakura.ne.jp ([202.181.97.72]:61313 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727306AbeHXAcY (ORCPT ); Thu, 23 Aug 2018 20:32:24 -0400 Received: from fsav103.sakura.ne.jp (fsav103.sakura.ne.jp [27.133.134.230]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id w7NL0t3f031144; Fri, 24 Aug 2018 06:00:55 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav103.sakura.ne.jp (F-Secure/fsigk_smtp/530/fsav103.sakura.ne.jp); Fri, 24 Aug 2018 06:00:55 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/530/fsav103.sakura.ne.jp) Received: from [192.168.1.8] (softbank060157066051.bbtec.net [60.157.66.51]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id w7NL0o9H031131 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 24 Aug 2018 06:00:55 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Subject: Re: [PATCH] mm,page_alloc: PF_WQ_WORKER threads must sleep at should_reclaim_retry(). To: David Rientjes Cc: Michal Hocko , Tejun Heo , Roman Gushchin , Johannes Weiner , Vladimir Davydov , Andrew Morton , Linus Torvalds , linux-mm , LKML References: <9158a23e-7793-7735-e35c-acd540ca59bf@i-love.sakura.ne.jp> <20180730144647.GX24267@dhcp22.suse.cz> <20180730145425.GE1206094@devbig004.ftw2.facebook.com> <0018ac3b-94ee-5f09-e4e0-df53d2cbc925@i-love.sakura.ne.jp> <20180730154424.GG1206094@devbig004.ftw2.facebook.com> <20180730185110.GB24267@dhcp22.suse.cz> <20180730191005.GC24267@dhcp22.suse.cz> <6f433d59-4a56-b698-e119-682bb8bf6713@i-love.sakura.ne.jp> <20180731050928.GA4557@dhcp22.suse.cz> <20180803061653.GB27245@dhcp22.suse.cz> <804b50cb-0b17-201a-790b-18604396f826@i-love.sakura.ne.jp> From: Tetsuo Handa Message-ID: Date: Fri, 24 Aug 2018 06:00:48 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/08/24 5:06, David Rientjes wrote: > For those of us who are tracking CVE-2016-10723 which has peristently been > labeled as "disputed" and with no clear indication of what patches address > it, I am assuming that commit 9bfe5ded054b ("mm, oom: remove sleep from > under oom_lock") and this patch are the intended mitigations? > > A list of SHA1s for merged fixed and links to proposed patches to address > this issue would be appreciated. > Commit 9bfe5ded054b ("mm, oom: remove sleep from under oom_lock") is a mitigation for CVE-2016-10723. "[PATCH] mm,page_alloc: PF_WQ_WORKER threads must sleep at should_reclaim_retry()." is independent from CVE-2016-10723. We haven't made sure that the OOM reaper / exit_mmap() will get enough CPU resources. For example, under a cluster of concurrently allocating realtime scheduling priority threads, the OOM reaper takes about 1800 milliseconds whereas direct OOM reaping takes only a few milliseconds. Regards.