From: Randy Dunlap <rdunlap@infradead.org>
To: LKML <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>
Cc: Li Yin <yin1.li@intel.com>,
Vadivel Murugan R <vadivel.muruganx.ramuthevar@linux.intel.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH -next] phy: fix USB_LGM_PHY warning & build errors
Date: Mon, 21 Sep 2020 08:45:01 -0700 [thread overview]
Message-ID: <cb3b277e-109d-82c5-9dec-153b4e035c2a@infradead.org> (raw)
In-Reply-To: <d1dd0ddd-3143-5777-1c63-195e1a32f237@infradead.org>
Ping. Still seeing this in linux-next.
On 9/17/20 10:51 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix a Kconfig warning that is causing lots of build errors
> when USB_SUPPORT is not set.
>
> USB_PHY depends on USB_SUPPORT but "select" doesn't care about
> dependencies, so this driver should also depend on USB_SUPPORT.
> It should not select USB_SUPPORT.
>
> WARNING: unmet direct dependencies detected for USB_PHY
> Depends on [n]: USB_SUPPORT [=n]
> Selected by [m]:
> - USB_LGM_PHY [=m]
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Li Yin <yin1.li@intel.com>
> Cc: Vadivel Murugan R <vadivel.muruganx.ramuthevar@linux.intel.com>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/phy/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20200917.orig/drivers/phy/Kconfig
> +++ linux-next-20200917/drivers/phy/Kconfig
> @@ -51,6 +51,7 @@ config PHY_XGENE
>
> config USB_LGM_PHY
> tristate "INTEL Lightning Mountain USB PHY Driver"
> + depends on USB_SUPPORT
> select USB_PHY
> select REGULATOR
> select REGULATOR_FIXED_VOLTAGE
>
--
~Randy
next prev parent reply other threads:[~2020-09-21 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 17:51 [PATCH -next] phy: fix USB_LGM_PHY warning & build errors Randy Dunlap
2020-09-21 15:45 ` Randy Dunlap [this message]
2020-09-22 4:21 ` Ramuthevar, Vadivel MuruganX
2020-09-22 14:12 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb3b277e-109d-82c5-9dec-153b4e035c2a@infradead.org \
--to=rdunlap@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=vkoul@kernel.org \
--cc=yin1.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).