From: David Lechner <david@lechnology.com>
To: Javier Martinez Canillas <javierm@redhat.com>,
linux-kernel@vger.kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Sam Ravnborg <sam@ravnborg.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/st7735r: Fix module autoloading for Okaya RH128128T
Date: Fri, 20 May 2022 10:33:37 -0500 [thread overview]
Message-ID: <cb4aadab-0724-35d6-0a97-dc4425f31bb9@lechnology.com> (raw)
In-Reply-To: <20220520091602.179078-1-javierm@redhat.com>
On 5/20/22 4:16 AM, Javier Martinez Canillas wrote:
> The SPI core always reports a "MODALIAS=spi:<foo>", even if the device was
> registered via OF. This means that the st7735r.ko module won't autoload if
> a DT has a node with a compatible "okaya,rh128128t" string.
>
> In that case, kmod expects a "MODALIAS=of:N*T*Cokaya,rh128128t" uevent but
> instead will get a "MODALIAS=spi:rh128128t", which is not present in the
> list of aliases:
>
> $ modinfo drivers/gpu/drm/tiny/st7735r.ko | grep alias
> alias: of:N*T*Cokaya,rh128128tC*
> alias: of:N*T*Cokaya,rh128128t
> alias: of:N*T*Cjianda,jd-t18003-t01C*
> alias: of:N*T*Cjianda,jd-t18003-t01
> alias: spi:jd-t18003-t01
>
> To workaround this issue, add in the SPI table an entry for that device.
>
> Fixes: d1d511d516f7 ("drm: tiny: st7735r: Add support for Okaya RH128128T")
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> ---
Acked-by: David Lechner <david@lechnology.com>
prev parent reply other threads:[~2022-05-20 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 9:16 [PATCH] drm/st7735r: Fix module autoloading for Okaya RH128128T Javier Martinez Canillas
2022-05-20 12:02 ` Geert Uytterhoeven
2022-05-23 14:11 ` Javier Martinez Canillas
2022-05-20 15:33 ` David Lechner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb4aadab-0724-35d6-0a97-dc4425f31bb9@lechnology.com \
--to=david@lechnology.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).