From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751578AbdAMLCw (ORCPT ); Fri, 13 Jan 2017 06:02:52 -0500 Received: from fllnx210.ext.ti.com ([198.47.19.17]:36142 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751526AbdAMLCs (ORCPT ); Fri, 13 Jan 2017 06:02:48 -0500 Subject: Re: [PATCH] usb: host: xhci: plat: check hcc_params after add hcd To: William Wu , References: <1484277533-30273-1-git-send-email-william.wu@rock-chips.com> CC: , , , , , , , , From: Roger Quadros Message-ID: Date: Fri, 13 Jan 2017 13:02:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1484277533-30273-1-git-send-email-william.wu@rock-chips.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 13/01/17 05:18, William Wu wrote: > From: William wu > > The commit 4ac53087d6d4 ("usb: xhci: plat: Create both > HCDs before adding them") move add hcd to the end of > probe, this cause hcc_params uninitiated, because xHCI > driver sets hcc_params in xhci_gen_setup() called from > usb_add_hcd(). > > This patch checks the Maximum Primary Stream Array Size > in the hcc_params register after add hcd. > > Signed-off-by: William wu > --- > drivers/usb/host/xhci-plat.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c > index ddfab30..52ce697 100644 > --- a/drivers/usb/host/xhci-plat.c > +++ b/drivers/usb/host/xhci-plat.c > @@ -232,9 +232,6 @@ static int xhci_plat_probe(struct platform_device *pdev) > if (device_property_read_bool(&pdev->dev, "usb3-lpm-capable")) > xhci->quirks |= XHCI_LPM_SUPPORT; > > - if (HCC_MAX_PSA(xhci->hcc_params) >= 4) > - xhci->shared_hcd->can_do_streams = 1; > - > hcd->usb_phy = devm_usb_get_phy_by_phandle(&pdev->dev, "usb-phy", 0); > if (IS_ERR(hcd->usb_phy)) { > ret = PTR_ERR(hcd->usb_phy); > @@ -255,6 +252,9 @@ static int xhci_plat_probe(struct platform_device *pdev) > if (ret) > goto dealloc_usb2_hcd; > > + if (HCC_MAX_PSA(xhci->hcc_params) >= 4) > + xhci->shared_hcd->can_do_streams = 1; > + xhci->hcc_params is initialized after the first usb_add_hcd(). Should this bit come before the usb_add_hcd(xhci->shared_hcd,..)? You will also need to copy to v4.2+ . Thanks. > return 0; > > > cheers, -roger