From: "Daniel Xu" <dxu@dxuuu.xyz>
To: "Steven Rostedt" <rostedt@goodmis.org>, jpoimboe@redhat.com
Cc: "Masami Hiramatsu" <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
kuba@kernel.org
Subject: Re: Broken kretprobe stack traces
Date: Thu, 04 Mar 2021 11:04:15 -0800 [thread overview]
Message-ID: <cb71589f-f724-4e98-b9a7-39024a78f0b7@www.fastmail.com> (raw)
In-Reply-To: <20210304021819.hgam3z3xurxcq3re@maharaja.localdomain>
On Wed, Mar 3, 2021, at 6:18 PM, Daniel Xu wrote:
> On Wed, Mar 03, 2021 at 03:37:40PM -0500, Steven Rostedt wrote:
> > On Wed, 03 Mar 2021 12:13:08 -0800
> > "Daniel Xu" <dxu@dxuuu.xyz> wrote:
> >
> > > On Wed, Mar 3, 2021, at 11:58 AM, Daniel Xu wrote:
> > > > On Wed, Mar 03, 2021 at 09:26:04AM -0500, Steven Rostedt wrote:
> > > > > On Wed, 3 Mar 2021 13:48:28 +0900
> > > > > Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > > > >
> > > > > >
> > > > > > >
> > > > > > > I think (can't prove) this used to work:
> > > > >
> > > > > Would be good to find out if it did.
> > > >
> > > > I'm installing some older kernels now to check. Will report back.
> > >
> > > Yep, works in 4.11. So there was a regression somewhere.
> >
> > Care to bisect? ;-)
>
> Took a while (I'll probably be typing "test_regression.sh" in my sleep
> tonight) but I've bisected it down to f95b23a112f1 ("Merge branch
> 'x86/urgent' into x86/asm, to pick up dependent fixes").
>
> I think I saw the default option for stack unwinder change from frame
> pointers -> ORC so that may be the root cause. Not sure, though. Need to
> look more closely at the commits in the merge commit.
>
> <...>
>
> Daniel
>
Compiling with:
CONFIG_UNWINDER_ORC=n
CONFIG_UNWINDER_FRAME_POINTER=y
fixes the issues and leads me to believe stacktraces on kretprobes
never worked with ORC.
Josh, any chance you have an idea?
Thanks,
Daniel
next prev parent reply other threads:[~2021-03-04 19:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 1:15 Broken kretprobe stack traces Daniel Xu
2021-03-03 4:48 ` Masami Hiramatsu
2021-03-03 14:26 ` Steven Rostedt
2021-03-03 19:58 ` Daniel Xu
2021-03-03 20:13 ` Daniel Xu
2021-03-03 20:37 ` Steven Rostedt
2021-03-04 2:18 ` Daniel Xu
2021-03-04 19:04 ` Daniel Xu [this message]
2021-03-04 13:19 ` Masami Hiramatsu
2021-03-04 15:22 ` [PATCH] kprobes: stacktrace: Recover the address changed by kretprobe kernel test robot
2021-03-04 17:37 ` kernel test robot
2021-03-04 20:25 ` kernel test robot
2021-03-03 19:57 ` Broken kretprobe stack traces Daniel Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb71589f-f724-4e98-b9a7-39024a78f0b7@www.fastmail.com \
--to=dxu@dxuuu.xyz \
--cc=bpf@vger.kernel.org \
--cc=jpoimboe@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).