From: "Zhang, Rui" <rui.zhang@intel.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: "mjg59@codon.org.uk" <mjg59@codon.org.uk>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"amitk@kernel.org" <amitk@kernel.org>,
"thara.gopinath@linaro.org" <thara.gopinath@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
"open list:ACPI THERMAL DRIVER" <linux-acpi@vger.kernel.org>
Subject: RE: [PATCH 4/6] acpi/drivers/thermal: Remove TRIPS_NONE cooling device binding
Date: Thu, 7 Jan 2021 05:10:35 +0000 [thread overview]
Message-ID: <cb755a9f2b314dcda0392fd5c08f7fb9@intel.com> (raw)
In-Reply-To: <1de4868e-6229-ed33-f45a-7cd82d3ee48a@linaro.org>
ACPI thermal driver binds the devices listed in _TZD method with THERMAL_TRIPS_NONE.
Now given that
1. THERMAL_TRIPS_NONE is removed from thermal framework
2. _TZP is rarely supported. I searched ~500 acpidumps from different platforms reported by end users in kernel Bugzilla, there is only one platform with _TZP implemented, and it was almost 10 years ago.
So, I think it is safe to remove this piece of code.
> -----Original Message-----
> From: Daniel Lezcano <daniel.lezcano@linaro.org>
> Sent: Tuesday, January 05, 2021 11:44 PM
> To: Zhang, Rui <rui.zhang@intel.com>
> Cc: mjg59@codon.org.uk; linux-pm@vger.kernel.org; linux-
> kernel@vger.kernel.org; amitk@kernel.org; thara.gopinath@linaro.org;
> Rafael J. Wysocki <rjw@rjwysocki.net>; Len Brown <lenb@kernel.org>; open
> list:ACPI THERMAL DRIVER <linux-acpi@vger.kernel.org>
> Subject: Re: [PATCH 4/6] acpi/drivers/thermal: Remove TRIPS_NONE cooling
> device binding
> Importance: High
>
> Hi Rui,
>
>
> On 15/12/2020 00:38, Daniel Lezcano wrote:
> > The loop is here to create default cooling device binding on the
> > THERMAL_TRIPS_NONE number which is used to be the 'forced_passive'
> > feature. However, we removed all code dealing with that in the thermal
> > core, thus this binding does no longer make sense.
> >
> > Remove it.
> >
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Zhang Rui <rui.zhang@intel.com>
Thanks,
rui
>
> Are you fine with this change?
>
> Thanks
>
> -- Daniel
>
> > ---
> > drivers/acpi/thermal.c | 19 -------------------
> > 1 file changed, 19 deletions(-)
> >
> > diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c index
> > b5e4bc9e3282..26a89ff80a0e 100644
> > --- a/drivers/acpi/thermal.c
> > +++ b/drivers/acpi/thermal.c
> > @@ -764,25 +764,6 @@ static int acpi_thermal_cooling_device_cb(struct
> thermal_zone_device *thermal,
> > }
> > }
> >
> > - for (i = 0; i < tz->devices.count; i++) {
> > - handle = tz->devices.handles[i];
> > - status = acpi_bus_get_device(handle, &dev);
> > - if (ACPI_SUCCESS(status) && (dev == device)) {
> > - if (bind)
> > - result = thermal_zone_bind_cooling_device
> > - (thermal,
> THERMAL_TRIPS_NONE,
> > - cdev, THERMAL_NO_LIMIT,
> > - THERMAL_NO_LIMIT,
> > -
> THERMAL_WEIGHT_DEFAULT);
> > - else
> > - result =
> thermal_zone_unbind_cooling_device
> > - (thermal,
> THERMAL_TRIPS_NONE,
> > - cdev);
> > - if (result)
> > - goto failed;
> > - }
> > - }
> > -
> > failed:
> > return result;
> > }
> >
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-
> blog/> Blog
next prev parent reply other threads:[~2021-01-07 5:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 23:38 [PATCH 1/6] thermal/core: Remove the 'forced_passive' option Daniel Lezcano
2020-12-14 23:38 ` [PATCH 2/6] thermal/core: Remove unused functions rebind/unbind exception Daniel Lezcano
2021-01-11 23:15 ` Thara Gopinath
2020-12-14 23:38 ` [PATCH 3/6] thermal/core: Remove pointless test with the THERMAL_TRIPS_NONE macro Daniel Lezcano
2021-01-11 23:17 ` Thara Gopinath
2020-12-14 23:38 ` [PATCH 4/6] acpi/drivers/thermal: Remove TRIPS_NONE cooling device binding Daniel Lezcano
2021-01-05 15:44 ` Daniel Lezcano
2021-01-07 5:10 ` Zhang, Rui [this message]
2021-01-07 16:46 ` Daniel Lezcano
2020-12-14 23:38 ` [PATCH 5/6] thermal/core: Remove THERMAL_TRIPS_NONE test Daniel Lezcano
2021-01-11 23:18 ` Thara Gopinath
2020-12-14 23:38 ` [PATCH 6/6] thermal/core: Remove unused macro THERMAL_TRIPS_NONE Daniel Lezcano
2021-01-11 23:18 ` Thara Gopinath
2020-12-22 17:05 ` [PATCH 1/6] thermal/core: Remove the 'forced_passive' option Daniel Lezcano
2021-01-11 23:13 ` Thara Gopinath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb755a9f2b314dcda0392fd5c08f7fb9@intel.com \
--to=rui.zhang@intel.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mjg59@codon.org.uk \
--cc=rjw@rjwysocki.net \
--cc=thara.gopinath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).