From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A439C433EF for ; Thu, 3 Mar 2022 10:38:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232426AbiCCKiz (ORCPT ); Thu, 3 Mar 2022 05:38:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232138AbiCCKix (ORCPT ); Thu, 3 Mar 2022 05:38:53 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1510F8A6D4 for ; Thu, 3 Mar 2022 02:38:06 -0800 (PST) Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 98DDE3F1C5 for ; Thu, 3 Mar 2022 10:38:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646303885; bh=xOhToe4x9f97Ns7B9xh5lureiPwRVmCdE7nXxruX5Ts=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ooKEqFUGOYfqprRWuxNZJg3ymUIdePcCluVxYca0fXK/vHIAsLYYoFlNOODAzncR+ Hfwmr1rho+t/ji9nm2g+ig3qW6bOpT3JBbej1oLRjuNRuSKpr2RrTip7Xbts8+AAAM MEqPwvqFzmsETDgdaZdWMnLvVXXRiYeKkDbM5kkdCGFF5IjxG53wZEigeGfbSpt1Yu Agz+xFqwTdMRiT37FrHnSfklcllM4vUZdl1lcIBzzf/eu/SaHiNFDxSvWK3JBLNp9D phzfTFVQ8hZ2MCOzZaZDV9M4XqEU7m0dZZXkzit+R4EDo3T6ZOkcUhIxTpYJ6Eq78h TXXmCB1VqhPqQ== Received: by mail-lf1-f69.google.com with SMTP id i24-20020a0565123e1800b0044567f5a29bso1451857lfv.5 for ; Thu, 03 Mar 2022 02:38:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=xOhToe4x9f97Ns7B9xh5lureiPwRVmCdE7nXxruX5Ts=; b=r8EaV/SwC9CWE+dUVGLreIkdxSJKeeQROqmpdc1HibhrUuJNdZJH3enY8AtFZuBD+e 3PUs+XJ2nuZDAssui6SsE/6pZxlMyR4HVwNIkDuKHV/Zu7ic0Xcjt+8ctlagpoirvqx0 tUhfHSKc/cRyfVOivOwX7CCgTeUeTtVZU6mobQuT+pvtAOzhLFasIFITEVheckA+Rg2T 1cm8RwHadzzDIOgw/Xuy/UD5tuKpLOVW/yxlEGVqkRPJjrxtLCTmzSoOJtKQPPGvJXow w2Ut+sfWFxGAfC6yLFw29/GSfaZvc+h1ZqDnBH5TO0G4NkM8hE6hLJ+4OYbdklv+uPfG 2+Sg== X-Gm-Message-State: AOAM533Ayqr6MkWl33AqRvAjs7cRU1PDCrG3bz+dAFnQ83gP9EidWCfu e8SaDwVHKNnhUJxhuadeg+h43TuwQEQ2MsICeKIB2CHjFcxrqH3iPGExilfQLJIuuYYJV1E1TnW IqgiTGX6mpTTIDx22UqzcEkWyA1fTSp1JE5+15PhySQ== X-Received: by 2002:a17:906:e04:b0:6ce:e210:4fe1 with SMTP id l4-20020a1709060e0400b006cee2104fe1mr27319538eji.402.1646303874423; Thu, 03 Mar 2022 02:37:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJyDYZj81Rphl4dYoYk1zvBPAtcEQQ07HvJC+n5Qx67PuSrOxEweiOj+yiH/LR8TWEP9H/K4/Q== X-Received: by 2002:a17:906:e04:b0:6ce:e210:4fe1 with SMTP id l4-20020a1709060e0400b006cee2104fe1mr27319499eji.402.1646303874194; Thu, 03 Mar 2022 02:37:54 -0800 (PST) Received: from [192.168.0.137] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id d23-20020a1709067a1700b006d0ebe4af89sm558554ejo.20.2022.03.03.02.37.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 02:37:53 -0800 (PST) Message-ID: Date: Thu, 3 Mar 2022 11:37:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 02/11] dt-bindings: i2c: npcm: support NPCM845 Content-Language: en-US To: Tyrone Ting , avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, yangyicong@hisilicon.com, semen.protsenko@linaro.org, wsa@kernel.org, jie.deng@intel.com, sven@svenpeter.dev, bence98@sch.bme.hu, lukas.bulwahn@gmail.com, arnd@arndb.de, olof@lixom.net, andriy.shevchenko@linux.intel.com, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com Cc: openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220303083141.8742-1-warp5tw@gmail.com> <20220303083141.8742-3-warp5tw@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220303083141.8742-3-warp5tw@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/03/2022 09:31, Tyrone Ting wrote: > From: Tyrone Ting > > Add compatible and nuvoton,sys-mgr description for NPCM i2c module. > > Signed-off-by: Tyrone Ting > Signed-off-by: Tali Perry > --- > .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 26 +++++++++++++++---- > 1 file changed, 21 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > index 128444942aec..37976ddcf406 100644 > --- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > @@ -7,17 +7,18 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > title: nuvoton NPCM7XX I2C Controller Device Tree Bindings > > description: | > - The NPCM750x includes sixteen I2C bus controllers. All Controllers support > - both master and slave mode. Each controller can switch between master and slave > - at run time (i.e. IPMB mode). Each controller has two 16 byte HW FIFO for TX and > - RX. > + I2C bus controllers of the NPCM series support both master and > + slave mode. Each controller can switch between master and slave at run time > + (i.e. IPMB mode). HW FIFO for TX and RX are supported. > > maintainers: > - Tali Perry > > properties: > compatible: > - const: nuvoton,npcm750-i2c > + enum: > + - nuvoton,npcm750-i2c > + - nuvoton,npcm845-i2c > > reg: > maxItems: 1 > @@ -36,6 +37,10 @@ properties: > default: 100000 > enum: [100000, 400000, 1000000] > > + nuvoton,sys-mgr: > + $ref: "/schemas/types.yaml#/definitions/phandle" > + description: The phandle of system manager register node. > + > required: > - compatible > - reg > @@ -44,6 +49,16 @@ required: > > allOf: > - $ref: /schemas/i2c/i2c-controller.yaml# > + - if: > + properties: > + compatible: > + contains: > + const: > + - nuvoton,npcm845-i2c This should be one line in const (not an enum). Rest looks good to me. Best regards, Krzysztof