From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752102AbdLISGm (ORCPT ); Sat, 9 Dec 2017 13:06:42 -0500 Received: from mout.web.de ([212.227.15.14]:52649 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106AbdLISGj (ORCPT ); Sat, 9 Dec 2017 13:06:39 -0500 Subject: [PATCH 3/3] serial: ioc3: Adjust two function calls together with a variable assignment From: SF Markus Elfring To: linux-serial@vger.kernel.org, linux-ia64@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Pat Gefre Cc: LKML , kernel-janitors@vger.kernel.org References: <962f1172-3f27-c6b5-653f-c09f2e8fe431@users.sourceforge.net> Message-ID: Date: Sat, 9 Dec 2017 19:06:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <962f1172-3f27-c6b5-653f-c09f2e8fe431@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:aaaROJlgPG1E8M02nFOk4dLvBxNSPTcu/DQYOmK2R6bC7rf+5tg 4irVFjpC5HaseLBG2RNuYnwiyvZTdPvCbuFg8xm/zNu2B9dkIjDbBeecWmSzPtkS36LulLp 93kYxRQ38FFmfxApIvEA4VOJ01wSwv0p702e4JaopI0lGl+6T7lB5UujjAi6ZQh41nQdHD0 6cR8FlY9iYn1TxjrgJrTw== X-UI-Out-Filterresults: notjunk:1;V01:K0:uaeB0BA2udg=:DxDPF8UFbFGo0n2udFsyaY Gc2YaJhornG8LdBJUMnvmKiGFS9zrMR70NXCv+aDIlsn6gAI7aEzlcfp/9EpPQAE99BDaEBXN hhhRxRStGFfJjry5oHy6OFq/KBQH2ynfEE0RoJc0UOlX0cZcPOtbsrDT1Tw8p0SZJDb8t/hlw UEcD4YHrSiN+XNiU1m4vqQRkmAAENEeawxxqq8rbbLbsmApmWEOMimO8s1b/W/ARMJHakPZA8 Z06KVCLUXEsgp2YaHyJk4o9xKeVJbmj1GhyW5Vg69zCZJprVI1rqD3dKBDWedfJy6SHfqzHzA T+EPyI/3yXCOW8o8U9GDtS0XZ0PowH0/ZNgWMZnCv4yiPlrKoGIzqKjTliVFk1bvSYPJmDkl4 IJz82ZT9OLLCd+m0Zs1b8RfX9yt7WdhjhJHqVRTuox1r2VcJMJV81b0fLiyQ8uy4XhYV8znZF mFk0Kw74HkxywODjtCS71jaCI4htoWvEJ2g7wQkQ9X033C98Kq3/ATRdJ81B97XY6kFKHCgZe TKI2OnRVw/83GrQaSHFucVTXPijNY8UHLac8uZMaSQ6Gy+0q5gzvMk8HJeTQ+UnxtBecd2MbK qbxJGokQsHLK1KEdXeTUFYvR73qNbDfHgGx8lWDemNd/eMpRcuuI/wqG4wxrI45O6CkYZZ05f F8uT40rKyN3XheSsTp60Ak1VT/nYDYodGIAP48Co7DyWNJSQ1ynGyq2NLu5+TNg5fS9+4JVaG p2mF16GweZ65rFy8AhBJFNSLsmnxGNUVSYpZNodYVwB2tyCpzKWUK4Io18RygF3gsvuwc+cCN cZ74OWh3oVM5Zke/MTy7U1NUlg6JsXcd75puyhgHOA9SSk3jtU= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 9 Dec 2017 18:48:57 +0100 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/tty/serial/ioc3_serial.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/ioc3_serial.c b/drivers/tty/serial/ioc3_serial.c index d211bb1407d3..0170d6f2bcdf 100644 --- a/drivers/tty/serial/ioc3_serial.c +++ b/drivers/tty/serial/ioc3_serial.c @@ -1540,8 +1540,8 @@ ioc3uart_intr_one(struct ioc3_submodule *is, * hasn't been delivered to the cpu yet anyway, even * though we see it as asserted when we read the sio_ir. */ - if ((sio_ir = PENDING(card_ptr, idd)) - & hooks->intr_rx_high) { + sio_ir = PENDING(card_ptr, idd); + if (sio_ir & hooks->intr_rx_high) { if (port->ip_flags & READ_ABORTED) { rx_high_rd_aborted++; } @@ -2162,10 +2162,10 @@ static struct ioc3_submodule ioc3uart_ops = { */ static int __init ioc3uart_init(void) { - int ret; - /* register with serial core */ - if ((ret = uart_register_driver(&ioc3_uart)) < 0) { + int ret = uart_register_driver(&ioc3_uart); + + if (ret < 0) { printk(KERN_WARNING "%s: Couldn't register IOC3 uart serial driver\n", __func__); -- 2.15.1