From: Joe Jin <joe.jin@oracle.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH V2] xen: export device state to sysfs
Date: Tue, 28 Aug 2018 10:14:05 -0700 [thread overview]
Message-ID: <cb9d797b-0df1-8bb2-93b3-34caf6da6f30@oracle.com> (raw)
In-Reply-To: <6cccd58c-f962-ac4b-bfb4-08df8432f4e5@oracle.com>
On 8/28/18 9:53 AM, Boris Ostrovsky wrote:
> On 08/28/2018 10:56 AM, Joe Jin wrote:
>> Export device state to sysfs to allow for easier get device state.
>>
>> Signed-off-by: Joe Jin <joe.jin@oracle.com>
>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> Cc: Juergen Gross <jgross@suse.com>
>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> ---
>> Documentation/ABI/stable/sysfs-bus-xen-backend | 9 +++++++++
>> drivers/xen/xenbus/xenbus_probe.c | 9 +++++++++
>> 2 files changed, 18 insertions(+)
>>
>> diff --git a/Documentation/ABI/stable/sysfs-bus-xen-backend b/Documentation/ABI/stable/sysfs-bus-xen-backend
>> index 3d5951c8bf5f..e8b60bd766f7 100644
>> --- a/Documentation/ABI/stable/sysfs-bus-xen-backend
>
>
> Won't this show up in the frontend as well?
Yes it will, current there is no any ABI document for xen-frontend.
Thanks,
Joe
>
> -boris
>
>> +++ b/Documentation/ABI/stable/sysfs-bus-xen-backend
>> @@ -73,3 +73,12 @@ KernelVersion: 3.0
>> Contact: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> Description:
>> Number of sectors written by the frontend.
>> +
>> +What: /sys/bus/xen-backend/devices/*/state
>> +Date: August 2018
>> +KernelVersion: 4.19
>> +Contact: Joe Jin <joe.jin@oracle.com>
>> +Description:
>> + The state of the device. One of: 'Unknown',
>> + 'Initialising', 'Initialised', 'Connected', 'Closing',
>> + 'Closed', 'Reconfiguring', 'Reconfigured'.
>> diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
>> index f2088838f690..5b471889d723 100644
>> --- a/drivers/xen/xenbus/xenbus_probe.c
>> +++ b/drivers/xen/xenbus/xenbus_probe.c
>> @@ -402,10 +402,19 @@ static ssize_t modalias_show(struct device *dev,
>> }
>> static DEVICE_ATTR_RO(modalias);
>>
>> +static ssize_t state_show(struct device *dev,
>> + struct device_attribute *attr, char *buf)
>> +{
>> + return sprintf(buf, "%s\n",
>> + xenbus_strstate(to_xenbus_device(dev)->state));
>> +}
>> +static DEVICE_ATTR_RO(state);
>> +
>> static struct attribute *xenbus_dev_attrs[] = {
>> &dev_attr_nodename.attr,
>> &dev_attr_devtype.attr,
>> &dev_attr_modalias.attr,
>> + &dev_attr_state.attr,
>> NULL,
>> };
>>
>
next prev parent reply other threads:[~2018-08-28 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 14:56 [PATCH V2] xen: export device state to sysfs Joe Jin
2018-08-28 16:53 ` Boris Ostrovsky
2018-08-28 17:14 ` Joe Jin [this message]
2018-08-28 22:26 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb9d797b-0df1-8bb2-93b3-34caf6da6f30@oracle.com \
--to=joe.jin@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).