linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Yi Wang <wang.yi59@zte.com.cn>, tglx@linutronix.de
Cc: mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org,
	keescook@chromium.org, luto@amacapital.net, wad@chromium.org,
	konrad.wilk@oracle.com, dhowells@redhat.com,
	linux-kernel@vger.kernel.org, riel@redhat.com,
	viro@ZenIV.linux.org.uk, zhong.weidong@zte.com.cn
Subject: Re: [PATCH] fork: Fix two -Wmissing-prototypes warnings
Date: Tue, 13 Nov 2018 11:26:47 +0100	[thread overview]
Message-ID: <cba61508-3e50-f8df-d75a-37d2e41a17c4@rasmusvillemoes.dk> (raw)
In-Reply-To: <1542093988-42041-1-git-send-email-wang.yi59@zte.com.cn>

On 13/11/2018 08.26, Yi Wang wrote:
> We get two warning when building kernel with W=1:
> kernel/fork.c:167:13: warning: no previous prototype for ‘arch_release_thread_stack’ [-Wmissing-prototypes]
> kernel/fork.c:779:13: warning: no previous prototype for ‘fork_init’ [-Wmissing-prototypes]

I think you should also remove the "manual" declarations from the .c
files that call the function, in this case fork_init() in  init/main.c;
otherwise there's no guarantee that those translation units actually
include the header that contain the proper declaration.

arch_release_thread_stack can probably just be removed completely after
the recent arch cleanup, since bb9d81264 (arch: remove tile port) no
arch seems to implement it.

Rasmus

      reply	other threads:[~2018-11-13 10:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13  7:26 [PATCH] fork: Fix two -Wmissing-prototypes warnings Yi Wang
2018-11-13 10:26 ` Rasmus Villemoes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cba61508-3e50-f8df-d75a-37d2e41a17c4@rasmusvillemoes.dk \
    --to=linux@rasmusvillemoes.dk \
    --cc=bp@alien8.de \
    --cc=dhowells@redhat.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=viro@ZenIV.linux.org.uk \
    --cc=wad@chromium.org \
    --cc=wang.yi59@zte.com.cn \
    --cc=x86@kernel.org \
    --cc=zhong.weidong@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).