From: Matthias Brugger <matthias.bgg@gmail.com>
To: Bilal Wasim <bilalwasim676@gmail.com>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, enric.balletbo@collabora.com,
hsinyi@chromium.org, weiyi.lu@mediatek.com
Subject: Re: [PATCH v2 2/3] soc: mediatek: pm-domains: Add domain_supply cap for mfg_async PD
Date: Wed, 31 Mar 2021 12:48:00 +0200 [thread overview]
Message-ID: <cbad9d05-6acb-eb11-a46e-4a2ccc634128@gmail.com> (raw)
In-Reply-To: <20210201121416.1488439-3-Bilal.Wasim@imgtec.com>
On 01/02/2021 13:14, Bilal Wasim wrote:
> The mfg_async power domain in mt8173 is used to power up imgtec
> gpu. This domain requires the da9211 regulator to be enabled before
> the power domain can be enabled successfully.
>
> Signed-off-by: Bilal Wasim <Bilal.Wasim@imgtec.com>
> Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> drivers/soc/mediatek/mt8173-pm-domains.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/mediatek/mt8173-pm-domains.h b/drivers/soc/mediatek/mt8173-pm-domains.h
> index 3e8ee5dabb43..065b8195e7d6 100644
> --- a/drivers/soc/mediatek/mt8173-pm-domains.h
> +++ b/drivers/soc/mediatek/mt8173-pm-domains.h
> @@ -63,6 +63,7 @@ static const struct scpsys_domain_data scpsys_domain_data_mt8173[] = {
> .ctl_offs = SPM_MFG_ASYNC_PWR_CON,
> .sram_pdn_bits = GENMASK(11, 8),
> .sram_pdn_ack_bits = 0,
> + .caps = MTK_SCPD_DOMAIN_SUPPLY,
Hm, I think the problem here is, that we don't find the regulator
"domain-supply" in the DTS. And that provokes that we error out on all power
domains. Not sure if we should fix that somehow, so that a missing regulator
will only affect one power domain (and it's childs).
Regards,
Matthias
> },
> [MT8173_POWER_DOMAIN_MFG_2D] = {
> .sta_mask = PWR_STATUS_MFG_2D,
>
next prev parent reply other threads:[~2021-03-31 10:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 12:14 [PATCH v2 0/3] Misc bug fixes in mtk power domain driver Bilal Wasim
2021-02-01 12:14 ` [PATCH v2 1/3] soc: mediatek: pm-domains: Use correct mask for bus_prot_clr Bilal Wasim
2021-03-31 11:01 ` Matthias Brugger
2021-02-01 12:14 ` [PATCH v2 2/3] soc: mediatek: pm-domains: Add domain_supply cap for mfg_async PD Bilal Wasim
2021-02-01 16:56 ` kernel test robot
2021-03-31 10:48 ` Matthias Brugger [this message]
2021-02-01 12:14 ` [PATCH v2 3/3] arm64: dts: mediatek: mt8173: Add domain supply for mfg_async Bilal Wasim
2021-02-16 11:59 ` [PATCH v2 0/3] Misc bug fixes in mtk power domain driver Bilal Wasim
2021-03-31 8:46 ` Enric Balletbo Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbad9d05-6acb-eb11-a46e-4a2ccc634128@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=bilalwasim676@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=weiyi.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).