From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC003C433EF for ; Tue, 24 May 2022 09:46:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235856AbiEXJqs (ORCPT ); Tue, 24 May 2022 05:46:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231445AbiEXJqp (ORCPT ); Tue, 24 May 2022 05:46:45 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDC482CDD7 for ; Tue, 24 May 2022 02:46:43 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id br17so17589546lfb.2 for ; Tue, 24 May 2022 02:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=IMbxClHWPS03PbbitBq3EQjBaeTdpKNatYW1zH8rzVo=; b=YHoPt3HgNPBuYbbTNSRtINqeAZgMQZGvk+Za2ftRzKkNR9F9TWpSdCLuDANiVg4Ha5 HlebbofUvH/fLuZbeMQf0JsfDkjNoZfqiR56opCYbjizHVYfPHHBXmbNXPMFRW+AuNlo xgaP/P2zVxyM8M0vuMHEdVM6b1ZV4L773kW3vlt7onYfpkCLa8yHzER9NeB0QxlTS6/m VwIDL8qnKLc/t2L1mpbtzn7Vv5VTcPDN6XE/LizsVC9VoIdYRqe7kuoMgnEC3PWyVvtk zj2TohBH9rkF2xAPJzaRBkQSyqluadvDmaDntru1tLs9PrsNVrd9JyKqeiIZpjP3FSCA fzVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IMbxClHWPS03PbbitBq3EQjBaeTdpKNatYW1zH8rzVo=; b=LrTvDSy/BuTyKs7tgpGaeGl3NgsY2vLRXbPxIcWaJWcX1x+DWU9kVI/l2FhdpJUi5g z64CjUBfvKeeF77x2KgIc+t/X6wtUHvV4WV0jPpwJRBFhOoTCcTn+L7BLvyf433wzdAO 1smbNd+Z2jKTr3aWYW4+mBE2j+Q9KatIS/uRBUFO/XP9EbJyYBxcB5jzygaTYp9A+If/ B8pe4PHotJj/fQUlA5veJRshOsNJT9yVujpGfhtvs8DCWPs+k1U0NdhlbhBoeEdC7A2L t6sxj8VJQ/xY6b6VOCcgFP8hx+jtQyQQjFb7gEGTAIxqhAcuDx+AawOADN/2tQdzhoJD 9A3A== X-Gm-Message-State: AOAM532sy48iZNl5pmMTPqfiQotscInrSeL+6p7kC8hOvRD4waXohZlp 1HZlYoHGasw89UAvI9yd85YJTsRwK4G+bA== X-Google-Smtp-Source: ABdhPJxYev9XNLxFP7wwILeL72uQun1SCV/fVs8X5/P+XotqeyeO0wiY2eMv6f5dNGdPO9WpfO3cZA== X-Received: by 2002:a05:6512:12c6:b0:477:990f:f56e with SMTP id p6-20020a05651212c600b00477990ff56emr18743357lfg.249.1653385602190; Tue, 24 May 2022 02:46:42 -0700 (PDT) Received: from [172.20.68.48] ([91.221.145.6]) by smtp.gmail.com with ESMTPSA id q17-20020ac25111000000b0047861cba7bdsm1613359lfb.53.2022.05.24.02.46.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 May 2022 02:46:41 -0700 (PDT) Message-ID: Date: Tue, 24 May 2022 11:46:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH V2 1/2] bindings: fsl-imx-sdma: Document 'HDMI Audio' transfer Content-Language: en-US To: Joy Zou , vkoul@kernel.org Cc: shengjiu.wang@nxp.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220524080337.1322240-1-joy.zou@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20220524080337.1322240-1-joy.zou@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/05/2022 10:03, Joy Zou wrote: > Add HDMI Audio transfer type. > > convert the sdma bindings txt into yaml in v2. > > Signed-off-by: Joy Zou > --- > Changes since v1: > convert the sdma bindings txt into yaml in v2. > --- > .../devicetree/bindings/dma/fsl-imx-sdma.yaml | 135 ++++++++++++++++++ There is no conversion here, only new file... > 1 file changed, 135 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/fsl-imx-sdma.yaml > > diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-sdma.yaml b/Documentation/devicetree/bindings/dma/fsl-imx-sdma.yaml > new file mode 100644 > index 000000000000..5b4f7a09a395 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/fsl-imx-sdma.yaml Filename: fsl,imx-sdma.yaml > @@ -0,0 +1,135 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/fsl-imx-sdma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale Smart Direct Memory Access (SDMA) Controller for i.MX > + > +maintainers: > + - Vinod Koul This should not be subsystem maintainer but someone closer to the actual device. > + > +allOf: > + - $ref: "dma-controller.yaml#" > + > +# Everything else is described in the common file Skip the comment please. > + > +properties: > + compatible: > + items: > + - enum: > + - fsl,imx25-sdma > + - fsl,imx31-sdma > + - fsl,imx31-to1-sdma > + - fsl,imx31-to2-sdma > + - fsl,imx35-to1-sdma > + - fsl,imx35-to2-sdma > + - fsl,imx51-sdma > + - fsl,imx53-sdma > + - fsl,imx6q-sdma > + - fsl,imx7d-sdma > + - fsl,imx6sx-sdma > + - fsl,imx6ul-sdma > + - fsl,imx8mm-sdma > + - fsl,imx8mn-sdma > + - fsl,imx8mp-sdma > + - enum: > + - fsl,imx35-sdma > + - fsl,imx8mq-sdma No, fallback cannot be variable. I doubt that fsl,imx25-sdma+fsl,imx8mq-sdma makes any sense! Additionally, this does not match existing DTS. Please run `make dtbs_check`. > + > + reg: > + description: Should contain SDMA registers location and length Skip description. Uou need to add maxItems > + > + interrupts: > + description: Should contain SDMA interrupt Skip description. Uou need to add maxItems > + > + fsl,sdma-ram-script-name: > + $ref: /schemas/types.yaml#/definitions/string > + description: Should contain the full path of SDMA RAM scripts firmware. > + > + "#dma-cells": > + const: 3 > + description: | > + The first cell: request/event ID > + > + The second cell: peripheral types ID > + enum: > + - MCU domain SSI: 0 > + - Shared SSI: 1 > + - MMC: 2 > + - SDHC: 3 > + - MCU domain UART: 4 > + - Shared UART: 5 > + - FIRI: 6 > + - MCU domain CSPI: 7 > + - Shared CSPI: 8 > + - SIM: 9 > + - ATA: 10 > + - CCM: 11 > + - External peripheral: 12 > + - Memory Stick Host Controller: 13 > + - Shared Memory Stick Host Controller: 14 > + - DSP: 15 > + - Memory: 16 > + - FIFO type Memory: 17 > + - SPDIF: 18 > + - IPU Memory: 19 > + - ASRC: 20 > + - ESAI: 21 > + - SSI Dual FIFO: 22 > + description: needs firmware more than ver 2> + - Shared ASRC: 23 > + - SAI: 24 > + - HDMI Audio: 25 > + > + The third cell: transfer priority ID > + enum: > + - High: 0 > + - Medium: 1 > + - Low: 2 > + > + gpr: > + description: The phandle to the General Purpose Register (GPR) node type/ref needed > + > + fsl,sdma-event-remap: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: | > + Register bits of sdma event remap, the format is . > + - reg: the GPR register offset > + - shift: the bit position inside the GPR register > + - val: the value of the bit (0 or 1) Need maxItems or items with description. > + > +required: > + - compatible > + - reg > + - interrupts > + - fsl,sdma-ram-script-name > + - "#dma-cells" > + > +unevaluatedProperties: false > + > +examples: > + - | > + sdma: dma-controller@83fb0000 { > + compatible = "fsl,imx51-sdma", "fsl,imx35-sdma"; > + reg = <0x83fb0000 0x4000>; > + interrupts = <6>; > + #dma-cells = <3>; > + fsl,sdma-ram-script-name = "sdma-imx51.bin"; > + }; > + > +#DMA clients connected to the i.MX SDMA controller must use the format > +#described in the dma-controller.yaml file. > + - | > + ssi2: ssi@70014000 { Skip consumer example, it's obvious. > + compatible = "fsl,imx51-ssi", "fsl,imx21-ssi"; > + reg = <0x70014000 0x4000>; > + interrupts = <30>; > + clocks = <&clks 49>; > + dmas = <&sdma 24 1 0>, > + <&sdma 25 1 0>; > + dma-names = "rx", "tx"; > + fsl,fifo-depth = <15>; > + }; > + > +... Best regards, Krzysztof