From: Sean Anderson <sean.anderson@seco.com>
To: Rob Herring <robh@kernel.org>
Cc: michal.simek@xilinx.com, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pwm: Add Xilinx AXI Timer
Date: Tue, 4 May 2021 10:51:10 -0400 [thread overview]
Message-ID: <cbb18e39-434b-0d67-12a9-6db943fe2bf5@seco.com> (raw)
In-Reply-To: <1620087689.365270.2706594.nullmailer@robh.at.kernel.org>
On 5/3/21 8:21 PM, Rob Herring wrote:
> On Mon, 03 May 2021 17:44:12 -0400, Sean Anderson wrote:
>> This adds a binding for the Xilinx LogiCORE IP AXI Timer. This device is
>> a "soft" block, so it has many parameters which would not be
>> configurable in most hardware. This binding is usually automatically
>> generated by Xilinx's tools, so the names and values of properties
>> must be kept as they are.
>>
>> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
>> ---
>>
>> .../bindings/pwm/xlnx,axi-timer.yaml | 91 +++++++++++++++++++
>> 1 file changed, 91 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/pwm/xlnx,axi-timer.yaml
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pwm/xlnx,axi-timer.example.dt.yaml: example-0: timer@800e0000:reg:0: [0, 2148401152, 0, 65536] is too long
> From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml
What is the correct way to specify the 'reg' property? I see many
schemas doing what I did here which is 'reg: maxItems: 1'. Should I
instead use 'reg: true'?
--Sean
>
> See https://patchwork.ozlabs.org/patch/1473421
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
prev parent reply other threads:[~2021-05-04 14:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 21:44 [PATCH 1/2] dt-bindings: pwm: Add Xilinx AXI Timer Sean Anderson
2021-05-03 21:44 ` [PATCH 2/2] pwm: Add support for " Sean Anderson
2021-05-04 2:24 ` kernel test robot
2021-05-04 9:03 ` Alvaro Gamez
2021-05-04 17:16 ` Sean Anderson
2021-05-04 5:21 ` Alvaro G. M.
2021-05-04 8:51 ` Uwe Kleine-König
2021-05-04 12:32 ` Michal Simek
2021-05-04 15:57 ` Sean Anderson
2021-05-04 16:13 ` Uwe Kleine-König
2021-05-05 6:31 ` Michal Simek
2021-05-04 14:46 ` Sean Anderson
2021-05-04 15:03 ` Sean Anderson
2021-05-04 17:15 ` Uwe Kleine-König
2021-05-04 18:01 ` Sean Anderson
2021-05-04 0:21 ` [PATCH 1/2] dt-bindings: pwm: Add " Rob Herring
2021-05-04 14:51 ` Sean Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbb18e39-434b-0d67-12a9-6db943fe2bf5@seco.com \
--to=sean.anderson@seco.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).