From: Randy Dunlap <rdunlap@bombadil.infradead.org>
To: Tom Saeger <tom.saeger@oracle.com>
Cc: Bhaskar Chowdhury <unixbhaskar@gmail.com>,
axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] Trivial typo fix and sentence construction for better readability
Date: Fri, 19 Mar 2021 13:08:36 -0700 (PDT) [thread overview]
Message-ID: <cbda62a9-16bc-6ea7-6070-95918b9154c7@bombadil.infradead.org> (raw)
In-Reply-To: <20210319200706.2dlq33ii33gyakyf@brm-x62-17.us.oracle.com>
On Fri, 19 Mar 2021, Tom Saeger wrote:
> On Fri, Mar 19, 2021 at 01:03:02PM -0700, Randy Dunlap wrote:
>>
>> Hm, needs some spacing fixes IMO. See below.
>>
>>
>> On Sat, 20 Mar 2021, Bhaskar Chowdhury wrote:
>>
>>>
>>> s/funtion/functions/
>>>
>>> Plus the sentence reconstructed for better readability.
>>>
>>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>>> ---
>>> Changes from V1:
>>> Randy's suggestions incorporated.
>>>
>>> block/blk-mq-tag.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
>>> index 9c92053e704d..c2bef283db63 100644
>>> --- a/block/blk-mq-tag.c
>>> +++ b/block/blk-mq-tag.c
>>> @@ -373,8 +373,8 @@ static bool blk_mq_tagset_count_completed_rqs(struct request *rq,
>>> }
>>>
>>> /**
>>> - * blk_mq_tagset_wait_completed_request - wait until all completed req's
>>> - * complete funtion is run
>
> completion function
>
> That's my read of it.
Sounds good. Thanks.
Bhaskar, please use this wording.
> --Tom
>
>>> + * blk_mq_tagset_wait_completed_request - wait until all the req's
>>
>> the req's
>>
>>> + * functions completed their run
>>
>> and more indentation + wording on that line above:
>> * functions have completed their run
>>
>>> * @tagset: Tag set to drain completed request
>>> *
>>> * Note: This function has to be run after all IO queues are shutdown
>>> --
>>
>> Thanks.
>
next prev parent reply other threads:[~2021-03-19 20:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 19:54 [PATCH V2] Trivial typo fix and sentence construction for better readability Bhaskar Chowdhury
2021-03-19 20:03 ` Randy Dunlap
2021-03-19 20:07 ` Tom Saeger
2021-03-19 20:08 ` Randy Dunlap [this message]
2021-03-19 20:07 ` Bhaskar Chowdhury
2021-03-19 20:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbda62a9-16bc-6ea7-6070-95918b9154c7@bombadil.infradead.org \
--to=rdunlap@bombadil.infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.saeger@oracle.com \
--cc=unixbhaskar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).