From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
<linux-kbuild@vger.kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Michal Marek <michal.lkml@markovi.net>,
Govind Singh <govinds@codeaurora.org>,
Kalle Valo <kvalo@codeaurora.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] kbuild: remove unnecessary $(subst $(obj)/,,...) in modname-multi
Date: Thu, 8 Mar 2018 18:19:52 +0800 [thread overview]
Message-ID: <cc031caa-3bf6-f8f0-6d82-1f01985ddd8a@cn.fujitsu.com> (raw)
In-Reply-To: <1520471103-10089-2-git-send-email-yamada.masahiro@socionext.com>
On 03/08/2018 09:04 AM, Masahiro Yamada wrote:
> In the context ...
>
> $(obj)/%.s: $(src)/%.c FORCE
> $(call if_changed_dep,cc_s_c)
>
> $(obj)/%.i: $(src)/%.c FORCE
> $(call if_changed_dep,cpp_i_c)
>
> $(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE
> $(call cmd,force_checksrc)
> $(call if_changed_rule,cc_o_c)
>
> $(obj)/%.lst: $(src)/%.c FORCE
> $(call if_changed_dep,cc_lst_c)
>
> '$*' returns the stem of the target (the part of '%'), so $(obj)/ has
> already been ripped off.
>
> $(subst $(obj)/,,$*.o) is the same as $(*.o)
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> scripts/Makefile.lib | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 5589bae..a7e315f 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -175,7 +175,7 @@ dtc_cpp_flags = -Wp,-MD,$(depfile).pre.tmp -nostdinc \
>
> # Finds the multi-part object the current object will be linked into
> modname-multi = $(sort $(foreach m,$(multi-used),\
> - $(if $(filter $(subst $(obj)/,,$*.o), $($(m:.o=-objs)) $($(m:.o=-y))),$(m:.o=))))
> + $(if $(filter $*.o, $($(m:.o=-objs)) $($(m:.o=-y))),$(m:.o=))))
>
> # Useful for describing the dependency of composite objects
> # Usage:
>
A subtle catch! And in my test, a debug line
$(info $@ = $*)
in rule:
$(obj)/%.o: $(src)/%.c xxx
does tell me it is correct. So,
Reviewed-by: Cao jin <caoj.fnst@cn.fujitsu.com>
--
Sincerely,
Cao jin
next prev parent reply other threads:[~2018-03-08 10:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 1:04 [PATCH 0/5] kbuild: always define KBUILD_MODNAME, and clean-up/fix modname Masahiro Yamada
2018-03-08 1:04 ` [PATCH 1/5] kbuild: remove unnecessary $(subst $(obj)/,,...) in modname-multi Masahiro Yamada
2018-03-08 10:19 ` Cao jin [this message]
2018-03-08 10:24 ` Masahiro Yamada
2018-03-08 1:05 ` [PATCH 2/5] kbuild: define KBUILD_MODNAME even if multiple modules share objects Masahiro Yamada
2018-03-08 10:11 ` Cao jin
2018-03-08 10:21 ` Masahiro Yamada
2018-03-08 10:25 ` Cao jin
2018-03-08 10:29 ` Masahiro Yamada
2018-03-08 1:05 ` [PATCH 3/5] kbuild: fix modname for composite modules Masahiro Yamada
2018-03-08 1:05 ` [PATCH 4/5] kbuild: simplify modname calculation Masahiro Yamada
2018-03-09 3:12 ` Cao jin
2018-03-08 1:05 ` [PATCH 5/5] kbuild: move modname and modname-multi close to modname_flags Masahiro Yamada
2018-03-09 3:13 ` Cao jin
2018-03-09 7:33 ` [PATCH 0/5] kbuild: always define KBUILD_MODNAME, and clean-up/fix modname Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc031caa-3bf6-f8f0-6d82-1f01985ddd8a@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=govinds@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=sam@ravnborg.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).