From: "Li,Rongqing" <lirongqing@baidu.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"hpa@zytor.com" <hpa@zytor.com>, "bp@alien8.de" <bp@alien8.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"joro@8bytes.org" <joro@8bytes.org>,
"jmattson@google.com" <jmattson@google.com>,
"wanpengli@tencent.com" <wanpengli@tencent.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"sean.j.christopherson@intel.com"
<sean.j.christopherson@intel.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: 答复: [PATCH][v2] kvm: x86: emulate APERF/MPERF registers
Date: Thu, 30 Apr 2020 09:50:08 +0000 [thread overview]
Message-ID: <cc0892c8066e421aba3a603edaf0a39a@baidu.com> (raw)
In-Reply-To: <5aa01c91-b874-fd4f-a1fb-1d008753ca84@intel.com>
> -----邮件原件-----
> 发件人: Xiaoyao Li [mailto:xiaoyao.li@intel.com]
> 发送时间: 2020年4月30日 14:49
> 收件人: Li,Rongqing <lirongqing@baidu.com>; linux-kernel@vger.kernel.org;
> kvm@vger.kernel.org; x86@kernel.org; hpa@zytor.com; bp@alien8.de;
> mingo@redhat.com; tglx@linutronix.de; joro@8bytes.org;
> jmattson@google.com; wanpengli@tencent.com; vkuznets@redhat.com;
> sean.j.christopherson@intel.com; pbonzini@redhat.com
> 主题: Re: [PATCH][v2] kvm: x86: emulate APERF/MPERF registers
>
> On 4/29/2020 1:46 PM, Li RongQing wrote:
> > Guest kernel reports a fixed cpu frequency in /proc/cpuinfo, this is
> > confused to user when turbo is enable, and aperf/mperf can be used to
> > show current cpu frequency after 7d5905dc14a
> > "(x86 / CPU: Always show current CPU frequency in /proc/cpuinfo)"
> > so we should emulate aperf mperf to achieve it
> >
> > the period of aperf/mperf in guest mode are accumulated as emulated
> > value, and add per-VM knod to enable emulate mperfaperf
> >
> > diff v1:
> > 1. support AMD
> > 2. support per-vm capability to enable
> >
> [...]
> > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index
> > 851e9cc79930..1d157a8dba46 100644
> > --- a/arch/x86/kvm/svm.c
> > +++ b/arch/x86/kvm/svm.c
> > @@ -4310,6 +4310,12 @@ static int svm_get_msr(struct kvm_vcpu *vcpu,
> struct msr_data *msr_info)
> > case MSR_F10H_DECFG:
> > msr_info->data = svm->msr_decfg;
> > break;
> > + case MSR_IA32_MPERF:
> > + msr_info->data = vcpu->arch.v_mperf;
> > + break;
> > + case MSR_IA32_APERF:
> > + msr_info->data = vcpu->arch.v_aperf;
> > + break;
> > default:
> > return kvm_get_msr_common(vcpu, msr_info);
> > }
> > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index
> > 91749f1254e8..b05e276e262b 100644
> > --- a/arch/x86/kvm/vmx/vmx.c
> > +++ b/arch/x86/kvm/vmx/vmx.c
> > @@ -1914,6 +1914,12 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu,
> struct msr_data *msr_info)
> > !guest_cpuid_has(vcpu, X86_FEATURE_RDTSCP))
> > return 1;
> > goto find_shared_msr;
> > + case MSR_IA32_MPERF:
> > + msr_info->data = vcpu->arch.v_mperf;
> > + break;
> > + case MSR_IA32_APERF:
> > + msr_info->data = vcpu->arch.v_aperf;
> > + break;
>
> They are same for both vmx and svm, you can put them in
> kvm_get_msr_common()
>
Ok
> BTW, are those two MSR always readable regardless of guest's CPUID?
It should be, not sure if there is abnormal
thanks
-LiRongQing
> > default:
> > find_shared_msr:
> > msr = find_msr_entry(vmx, msr_info->index);
>
prev parent reply other threads:[~2020-04-30 9:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 5:46 [PATCH][v2] kvm: x86: emulate APERF/MPERF registers Li RongQing
2020-04-29 8:54 ` Peter Zijlstra
2020-04-29 9:43 ` 答复: " Li,Rongqing
2020-04-29 10:21 ` Paolo Bonzini
2020-04-30 1:45 ` 答复: " Li,Rongqing
2020-04-30 6:49 ` Xiaoyao Li
2020-04-30 9:50 ` Li,Rongqing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc0892c8066e421aba3a603edaf0a39a@baidu.com \
--to=lirongqing@baidu.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).