From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEAB0C433E0 for ; Mon, 8 Jun 2020 12:57:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A7AF2076A for ; Mon, 8 Jun 2020 12:57:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HHsy2c0J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729751AbgFHM51 (ORCPT ); Mon, 8 Jun 2020 08:57:27 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:55892 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729562AbgFHM50 (ORCPT ); Mon, 8 Jun 2020 08:57:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591621044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cUm1Yo5Aid4TMrOqqlc50Lm+RhYPQ/fOeFf4c/GrH5w=; b=HHsy2c0JyXdMIxRfW0LPwZ5i4daoT6/wwrXDJzQQVSpZdFjTTMte/dbctW0POx16zwdjMq szvXWbA4gXnD0qi9DfhnYh3bJ2AK+HYf/mbWQMfkwuk1mmmo+B1aP2y+aGr9zr/r+5hGmN GmhEgkilblYtEplfXhoLNGXBElnb/o4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-X5_LaDo0MmOPSb_gmUsdlQ-1; Mon, 08 Jun 2020 08:57:23 -0400 X-MC-Unique: X5_LaDo0MmOPSb_gmUsdlQ-1 Received: by mail-wr1-f70.google.com with SMTP id l1so7110129wrc.8 for ; Mon, 08 Jun 2020 05:57:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cUm1Yo5Aid4TMrOqqlc50Lm+RhYPQ/fOeFf4c/GrH5w=; b=ch1pHnIlXJ57ImKZhsHKKSrdvkapJpHWs/K/XtJRf1x4kmZl0noZvFpT2mDn4xWFY4 pf04o9wTprNN10njlg/1Nwif+vRerxx6DsSBtDy0TYWrMfm/XS+2UrptiENy1Q0IWxLv c4h4VqELsIEQ3qDq05MwAv8sbm8g/bcyo7z8aHJ4GmCJRrxV7a6d/cLvFLrP2hpbEvTP uEX0xxwhLw+pU/BMZAMJeQPWYt6yJYCf++MHRfBjumWJ5VLVI9V+7RXn2JUOu7YFMQzl 7jpzZ0XQ7EKvahVCwvGIRJIWuxTGCiGyWue+8n1Z8Uxj8msBA1wSXj7szKChYMaLh+Tn Q2gA== X-Gm-Message-State: AOAM530fvp+gBTJjQUGE0hP6+oEj6KUVDF2A9NN97FPee8ekvij56Hxb r66C1JWnwhpUvKpx3vAIyUDLR/zqha+lpUjD8aPanrIomAx6AUdLip9smKs1G03qNI4eo+yT/9f KVvbYncEdJC7t2Gja/JFBsXNW X-Received: by 2002:a05:6000:4c:: with SMTP id k12mr23045673wrx.215.1591621041758; Mon, 08 Jun 2020 05:57:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6e3sTNx0BsPz+9n2RfJG0sF3B20sQwi851ltjAWHGGejg4F5dTAyhk0S80jQnxkAgrZInQQ== X-Received: by 2002:a05:6000:4c:: with SMTP id k12mr23045654wrx.215.1591621041544; Mon, 08 Jun 2020 05:57:21 -0700 (PDT) Received: from [192.168.178.58] ([151.30.87.23]) by smtp.gmail.com with ESMTPSA id s132sm23406546wmf.12.2020.06.08.05.57.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2020 05:57:21 -0700 (PDT) Subject: Re: [PATCH v2 17/18] kvm/eventfd: Use sequence counter with associated spinlock To: "Ahmed S. Darwish" , Peter Zijlstra , Ingo Molnar , Will Deacon Cc: Thomas Gleixner , "Paul E. McKenney" , "Sebastian A. Siewior" , Steven Rostedt , LKML , kvm@vger.kernel.org References: <20200519214547.352050-1-a.darwish@linutronix.de> <20200608005729.1874024-1-a.darwish@linutronix.de> <20200608005729.1874024-18-a.darwish@linutronix.de> From: Paolo Bonzini Message-ID: Date: Mon, 8 Jun 2020 14:57:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200608005729.1874024-18-a.darwish@linutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/06/20 02:57, Ahmed S. Darwish wrote: > A sequence counter write side critical section must be protected by some > form of locking to serialize writers. A plain seqcount_t does not > contain the information of which lock must be held when entering a write > side critical section. > > Use the new seqcount_spinlock_t data type, which allows to associate a > spinlock with the sequence counter. This enables lockdep to verify that > the spinlock used for writer serialization is held when the write side > critical section is entered. > > If lockdep is disabled this lock association is compiled out and has > neither storage size nor runtime overhead. > > Signed-off-by: Ahmed S. Darwish > --- > include/linux/kvm_irqfd.h | 2 +- > virt/kvm/eventfd.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/kvm_irqfd.h b/include/linux/kvm_irqfd.h > index dc1da020305b..dac047abdba7 100644 > --- a/include/linux/kvm_irqfd.h > +++ b/include/linux/kvm_irqfd.h > @@ -42,7 +42,7 @@ struct kvm_kernel_irqfd { > wait_queue_entry_t wait; > /* Update side is protected by irqfds.lock */ > struct kvm_kernel_irq_routing_entry irq_entry; > - seqcount_t irq_entry_sc; > + seqcount_spinlock_t irq_entry_sc; > /* Used for level IRQ fast-path */ > int gsi; > struct work_struct inject; > diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c > index 67b6fc153e9c..8694a2920ea9 100644 > --- a/virt/kvm/eventfd.c > +++ b/virt/kvm/eventfd.c > @@ -303,7 +303,7 @@ kvm_irqfd_assign(struct kvm *kvm, struct kvm_irqfd *args) > INIT_LIST_HEAD(&irqfd->list); > INIT_WORK(&irqfd->inject, irqfd_inject); > INIT_WORK(&irqfd->shutdown, irqfd_shutdown); > - seqcount_init(&irqfd->irq_entry_sc); > + seqcount_spinlock_init(&irqfd->irq_entry_sc, &kvm->irqfds.lock); > > f = fdget(args->fd); > if (!f.file) { > Acked-by: Paolo Bonzini