From: Shuah Khan <skhan@linuxfoundation.org>
To: Brendan Higgins <brendanhiggins@google.com>,
Daniel Latypov <dlatypov@google.com>
Cc: David Gow <davidgow@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
KUnit Development <kunit-dev@googlegroups.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] kunit: fix -Wunused-function warning for __kunit_fail_current_test
Date: Tue, 6 Apr 2021 15:19:08 -0600 [thread overview]
Message-ID: <cc19e30b-469d-6551-1c27-d51003afe90e@linuxfoundation.org> (raw)
In-Reply-To: <CAFd5g472E_Q-CoM2ONNONP_oeGZe0HGpNdqVhyRkKhP74b7h7A@mail.gmail.com>
On 4/6/21 2:50 PM, Brendan Higgins wrote:
> On Tue, Apr 6, 2021 at 10:29 AM Daniel Latypov <dlatypov@google.com> wrote:
>>
>> When CONFIG_KUNIT is not enabled, __kunit_fail_current_test() an empty
>> static function.
>>
>> But GCC complains about unused static functions, *unless* they're static inline.
>> So add inline to make GCC happy.
>>
>> Signed-off-by: Daniel Latypov <dlatypov@google.com>
>> Fixes: 359a376081d4 ("kunit: support failure from dynamic analysis tools")
>
Signed-off-by comes after Fixes. Also good to add Reported-by for
Stephen acknowledging the reporter.
I will fix this up when I apply - for future reference.
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
>
thanks,
-- Shuah
prev parent reply other threads:[~2021-04-06 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 17:29 [PATCH] kunit: fix -Wunused-function warning for __kunit_fail_current_test Daniel Latypov
2021-04-06 20:50 ` Brendan Higgins
2021-04-06 21:19 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc19e30b-469d-6551-1c27-d51003afe90e@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).