From: Guenter Roeck <linux@roeck-us.net>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Kyle Tso <kyletso@google.com>,
gregkh@linuxfoundation.org, hdegoede@redhat.com,
robh+dt@kernel.org, badhri@google.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/8] usb: typec: Manage SVDM version
Date: Wed, 3 Feb 2021 09:07:34 -0800 [thread overview]
Message-ID: <cc1f42a4-3cd8-f5ce-d3d6-f8f589242fec@roeck-us.net> (raw)
In-Reply-To: <20210203150419.GJ1687065@kuha.fi.intel.com>
On 2/3/21 7:04 AM, Heikki Krogerus wrote:
> On Wed, Feb 03, 2021 at 05:01:26PM +0200, Heikki Krogerus wrote:
>> On Wed, Feb 03, 2021 at 06:51:43AM -0800, Guenter Roeck wrote:
>>> Thinking about it, would it make make sense to define the functions as
>>> static inline ?
>>
>> I (and I believe Guenter too)
>
> s/I believe Guenter too/I thought you too/
>
Oops, you are correct. I somehow thought the structure holding the variable
was defined in an include file. Sorry, my bad. Please ignore the noise
I am making.
Guenter
>> want to keep these structures protected
>> for now. If the API starts to get too bloated, then I guess I have to
>> reconsider that. But I don't think we are there yet.
>>
>> I have been thinking about moving the USB PD negotiation details to a
>> separate structure that could be more accessible for everybody. That
>> should allow me continue to protect my precious structures. But I have
>> not yet put much though into that.
>
>
next prev parent reply other threads:[~2021-02-03 17:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 16:17 [PATCH v5 0/8] common SVDM version and VDO from dt Kyle Tso
2021-02-02 16:17 ` [PATCH v5 1/8] usb: typec: Manage SVDM version Kyle Tso
2021-02-03 12:47 ` Heikki Krogerus
2021-02-03 13:34 ` Heikki Krogerus
2021-02-03 14:51 ` Guenter Roeck
2021-02-03 15:01 ` Heikki Krogerus
2021-02-03 15:04 ` Heikki Krogerus
2021-02-03 15:42 ` Kyle Tso
2021-02-03 17:07 ` Guenter Roeck [this message]
2021-02-02 16:17 ` [PATCH v5 2/8] usb: pd: Update VDO definitions Kyle Tso
2021-02-03 12:48 ` Heikki Krogerus
2021-02-03 13:09 ` Greg KH
2021-02-03 16:54 ` Benson Leung
2021-02-04 2:24 ` Kyle Tso
2021-02-02 16:17 ` [PATCH v5 3/8] usb: pd: Make SVDM Version configurable in VDM header Kyle Tso
2021-02-02 16:17 ` [PATCH v5 4/8] usb: typec: tcpm: Detemine common SVDM Version Kyle Tso
2021-02-02 16:17 ` [PATCH v5 5/8] usb: typec: ucsi: " Kyle Tso
2021-02-02 16:17 ` [PATCH v5 6/8] usb: typec: displayport: Fill the negotiated SVDM Version in the header Kyle Tso
2021-02-02 16:17 ` [PATCH v5 7/8] dt-bindings: connector: Add SVDM VDO properties Kyle Tso
2021-02-02 16:17 ` [PATCH v5 8/8] usb: typec: tcpm: Get Sink VDO from fwnode Kyle Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc1f42a4-3cd8-f5ce-d3d6-f8f589242fec@roeck-us.net \
--to=linux@roeck-us.net \
--cc=badhri@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).