From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Bandan Das <bsd@redhat.com>, Nadav Amit <nadav.amit@gmail.com>
Subject: Re: [PATCH v3 4/4] KVM: x86: emulate FXSAVE and FXRSTOR
Date: Wed, 9 Nov 2016 00:25:22 +0100 [thread overview]
Message-ID: <cc4ad31c-b313-71a1-9087-f3abe4dc8d52@redhat.com> (raw)
In-Reply-To: <20161108195419.4607-5-rkrcmar@redhat.com>
On 08/11/2016 20:54, Radim Krčmář wrote:
> Internal errors were reported on 16 bit fxsave and fxrstor with ipxe.
> Old Intels don't have unrestricted_guest, so we have to emulate them.
>
> The patch takes advantage of the hardware implementation.
>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
> v3:
> - remove fxsave64 and extra colons at the end of asm to make old GCCs
> happy (fxsave64 could have been implemented using other nmemonics,
> but there is no point when it won't be used + removing it makes the
> code nicer.)
> v2:
> - throws #GP to the guest when reserved MXCSR are set [Nadav]
> - returns internal emulation error if an exception is hit during
> execution
> - preserves XMM 8-15
> ---
> arch/x86/kvm/emulate.c | 113 ++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 112 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index 6af3cac6ec89..1b3fab1fb8d3 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -3883,6 +3883,115 @@ static int em_movsxd(struct x86_emulate_ctxt *ctxt)
> return X86EMUL_CONTINUE;
> }
>
> +static int check_fxsr(struct x86_emulate_ctxt *ctxt)
> +{
> + u32 eax = 1, ebx, ecx = 0, edx;
> +
> + ctxt->ops->get_cpuid(ctxt, &eax, &ebx, &ecx, &edx);
> + if (!(edx & FFL(FXSR)))
> + return emulate_ud(ctxt);
> +
> + if (ctxt->ops->get_cr(ctxt, 0) & (X86_CR0_TS | X86_CR0_EM))
> + return emulate_nm(ctxt);
> +
> + /*
> + * Don't emulate a case that should never be hit, instead of working
> + * around a lack of fxsave64/fxrstor64 on old compilers.
> + */
> + if (ctxt->mode >= X86EMUL_MODE_PROT64)
> + return X86EMUL_UNHANDLEABLE;
> +
> + return X86EMUL_CONTINUE;
> +}
> +
> +/*
> + * FXSAVE and FXRSTOR have 4 different formats depending on execution mode,
> + * 1) 16 bit mode
> + * 2) 32 bit mode
> + * - like (1), but FIP and FDP (foo) are only 16 bit. At least Intel CPUs
> + * preserve whole 32 bit values, though, so (1) and (2) are the same wrt.
> + * save and restore
> + * 3) 64-bit mode with REX.W prefix
> + * - like (2), but XMM 8-15 are being saved and restored
> + * 4) 64-bit mode without REX.W prefix
> + * - like (3), but FIP and FDP are 64 bit
> + *
> + * Emulation uses (3) for (1) and (2) and preserves XMM 8-15 to reach the
> + * desired result. (4) is not emulated.
> + *
> + * XXX: Guest and host CPUID.(EAX=07H,ECX=0H):EBX[bit 13] (deprecate FPU CS
> + * and FPU DS) should match.
> + */
> +static int em_fxsave(struct x86_emulate_ctxt *ctxt)
> +{
> + struct fxregs_state fx_state;
> + size_t size = 288; /* up to XMM7 */
Sorry for noticing this only now; if CR4.OSFXSR is 0, XMM and MXCSR
should not be saved.
I can apply the first three patches already if you prefer.
Paolo
> + int rc;
> +
> + rc = check_fxsr(ctxt);
> + if (rc != X86EMUL_CONTINUE)
> + return rc;
> +
> + ctxt->ops->get_fpu(ctxt);
> +
> + rc = asm_safe("fxsave %[fx]", , [fx] "+m"(fx_state));
> +
> + ctxt->ops->put_fpu(ctxt);
> +
> + if (rc != X86EMUL_CONTINUE)
> + return rc;
> +
> + return segmented_write(ctxt, ctxt->memop.addr.mem, &fx_state, size);
> +}
> +
> +static int fx_load_64bit_xmm(struct fxregs_state *new)
> +{
> + int rc = X86EMUL_CONTINUE;
> +#ifdef CONFIG_X86_64
> + struct fxregs_state old;
> +
> + rc = asm_safe("fxsave %[fx]", , [fx] "+m"(old));
> +
> + /* XXX: accessing XMM 8-15 is very awkward */
> + memcpy(&new->xmm_space[8*16 / 4], &old.xmm_space[8*16 / 4], 8*16);
> +#endif
> + return rc;
> +}
> +
> +static int em_fxrstor(struct x86_emulate_ctxt *ctxt)
> +{
> + struct fxregs_state fx_state;
> + int rc;
> +
> + rc = check_fxsr(ctxt);
> + if (rc != X86EMUL_CONTINUE)
> + return rc;
> +
> + rc = segmented_read(ctxt, ctxt->memop.addr.mem, &fx_state, 512);
> + if (rc != X86EMUL_CONTINUE)
> + return rc;
> +
> + if (fx_state.mxcsr >> 16)
> + return emulate_gp(ctxt, 0);
> +
> + ctxt->ops->get_fpu(ctxt);
> +
> + /*
> + * 64 bit host will always restore XMM8-15, which is not correct on
> + * non-64 bit guests. Load the current values in order to preserve 64
> + * bit XMMs after fxrstor.
> + */
> + if (ctxt->mode < X86EMUL_MODE_PROT64)
> + rc = fx_load_64bit_xmm(&fx_state);
> +
> + if (rc == X86EMUL_CONTINUE)
> + rc = asm_safe("fxrstor %[fx]", : [fx] "m"(fx_state));
> +
> + ctxt->ops->put_fpu(ctxt);
> +
> + return rc;
> +}
> +
> static bool valid_cr(int nr)
> {
> switch (nr) {
> @@ -4235,7 +4344,9 @@ static const struct gprefix pfx_0f_ae_7 = {
> };
>
> static const struct group_dual group15 = { {
> - N, N, N, N, N, N, N, GP(0, &pfx_0f_ae_7),
> + I(ModRM | Aligned16, em_fxsave),
> + I(ModRM | Aligned16, em_fxrstor),
> + N, N, N, N, N, GP(0, &pfx_0f_ae_7),
> }, {
> N, N, N, N, N, N, N, N,
> } };
>
next prev parent reply other threads:[~2016-11-08 23:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 19:54 [PATCH v3 0/4] KVM: x86: emulate FXSAVE and FXRSTOR Radim Krčmář
2016-11-08 19:54 ` [PATCH v3 1/4] KVM: x86: add Align16 instruction flag Radim Krčmář
2016-11-08 19:54 ` [PATCH v3 2/4] KVM: x86: save one bit in ctxt->d Radim Krčmář
2016-11-08 19:54 ` [PATCH v3 3/4] KVM: x86: add asm_safe wrapper Radim Krčmář
2016-11-08 19:54 ` [PATCH v3 4/4] KVM: x86: emulate FXSAVE and FXRSTOR Radim Krčmář
2016-11-08 23:25 ` Paolo Bonzini [this message]
2016-11-09 12:12 ` Radim Krčmář
2016-11-09 14:19 ` Radim Krčmář
2016-11-09 18:07 ` [PATCH v4] " Radim Krčmář
2016-11-09 18:42 ` kbuild test robot
2016-11-09 18:46 ` Radim Krčmář
2016-11-10 2:47 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc4ad31c-b313-71a1-9087-f3abe4dc8d52@redhat.com \
--to=pbonzini@redhat.com \
--cc=bsd@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nadav.amit@gmail.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).