From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F363EC00140 for ; Tue, 2 Aug 2022 08:41:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236064AbiHBIlw (ORCPT ); Tue, 2 Aug 2022 04:41:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231859AbiHBIls (ORCPT ); Tue, 2 Aug 2022 04:41:48 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 210A31ADB1 for ; Tue, 2 Aug 2022 01:41:47 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id a9so8143257lfm.12 for ; Tue, 02 Aug 2022 01:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=zzB0a7bJOMuRv01PGiHsY1rvic1GuiUFISUsomCCCOo=; b=FGiOqoB701ZWcSGMUaQswKviPECFcCRkpb1CO5b7T7slyTtpMvgZLLV6NZv4POrW3A 8KxoyNm4hvlQ39tHXnv1WTlPGfm4VwNAbmheiMYG5htaEo9wiHviHhhbehHK9+BM69dZ NyZ3qlzJbke68yc7fuGUCf8nJYbMAcXy/exARn+DYXlbv/5Ldrl5wN1FhsetYXS/rNlo MsVvjSNyIdpmYIMdW+LURg68QqTKLFfEEha5nzX/+71DcMi352uN2HPEY2i/zJj5Vrob Sc7aki4z/6Cvxbx2OQ4zEY8V4gYluEfFcHvtaYS+MRvfu6PGwN79mL3GtQHxzWt/Rqec xT0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=zzB0a7bJOMuRv01PGiHsY1rvic1GuiUFISUsomCCCOo=; b=DFG/3Ke3scp9c3t388T3c2SYMbKVoC++KBk8+Jb76rQgxMwPTDeeaYpa2vJkKiZXCa GsadbB4HuVWv6D1+XZf89jn0q2UiZ2lkLcXGXgI2N1zy3X9/lkZVypyzn4ZTFkYi/Oza 0Fpw6+t/XEE6xS5abwHkYzUlsszFp/cG+xHTZO4GiMAmf6L5tJJwgEVOO9kQFP2I3ySx fV9XAohX73LF0B74otDZah5M/k5YkDIf5uTBtMyvpG1AXerk7QRNF7307BBZSovrn3Yh oVl2ZaQukH7xp/Xpg0Rv6kGsZ4Hq/4f1j0VXNesuk1Q9GDhzMh6yCuwevG9Duee/E0lb e8MQ== X-Gm-Message-State: AJIora8bchHzuOxf8kHhqB+Xp0fbWdp+i0jIfs9RebsWLEZOKcZJw0UF yzCzAzL4gGQo2/2h17C1DH4j/w== X-Google-Smtp-Source: AGRyM1vJSAY2q/uqhkA1XSIumtj2KvUDJDe8nq4mEflYQj1coZO+qe9bEl83kK9K5j3RD9tqV2NHeg== X-Received: by 2002:a19:6d0d:0:b0:48a:8b3c:e28 with SMTP id i13-20020a196d0d000000b0048a8b3c0e28mr6420470lfc.265.1659429705435; Tue, 02 Aug 2022 01:41:45 -0700 (PDT) Received: from [192.168.1.6] ([213.161.169.44]) by smtp.gmail.com with ESMTPSA id e12-20020a19674c000000b00489e2156285sm2021463lfj.104.2022.08.02.01.41.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 01:41:44 -0700 (PDT) Message-ID: Date: Tue, 2 Aug 2022 10:41:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/4] dt-bindings: net: dsa: mediatek,mt7530: make trivial changes Content-Language: en-US To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Landen Chao , DENG Qingfang , Frank Wunderlich , Luiz Angelo Daros de Luca , Sander Vanheule , =?UTF-8?Q?Ren=c3=a9_van_Dorst?= , Daniel Golle , erkin.bozoglu@xeront.com, Sergio Paracuellos Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220730142627.29028-1-arinc.unal@arinc9.com> <20220730142627.29028-2-arinc.unal@arinc9.com> From: Krzysztof Kozlowski In-Reply-To: <20220730142627.29028-2-arinc.unal@arinc9.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/07/2022 16:26, Arınç ÜNAL wrote: > Make trivial changes on the binding. > > - Update title to include MT7531 switch. > - Add me as a maintainer. List maintainers in alphabetical order by first > name. > - Add description to compatible strings. > - Fix MCM description. mediatek,mcm is not used on MT7623NI. > - Add description for reset-gpios. > - Remove quotes from $ref: "dsa.yaml#". > > Signed-off-by: Arınç ÜNAL > --- > .../bindings/net/dsa/mediatek,mt7530.yaml | 27 ++++++++++++++----- > 1 file changed, 20 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index 17ab6c69ecc7..541984a7d2d4 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -4,12 +4,13 @@ > $id: http://devicetree.org/schemas/net/dsa/mediatek,mt7530.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Mediatek MT7530 Ethernet switch > +title: Mediatek MT7530 and MT7531 Ethernet Switches > > maintainers: > - - Sean Wang > + - Arınç ÜNAL > - Landen Chao > - DENG Qingfang > + - Sean Wang > > description: | > Port 5 of mt7530 and mt7621 switch is muxed between: > @@ -66,6 +67,14 @@ properties: > - mediatek,mt7531 > - mediatek,mt7621 > > + description: | > + mediatek,mt7530: > + For standalone MT7530 and multi-chip module MT7530 in MT7623AI SoC. > + mediatek,mt7531: > + For standalone MT7531. > + mediatek,mt7621: > + For multi-chip module MT7530 in MT7621AT, MT7621DAT and MT7621ST SoCs. If compatible: is changed to oneOf, you can use description for each item. Look at board compatibles (arm/fsl.yaml) > + > reg: > maxItems: 1 > > @@ -79,7 +88,7 @@ properties: > gpio-controller: > type: boolean > description: > - if defined, MT7530's LED controller will run on GPIO mode. > + If defined, MT7530's LED controller will run on GPIO mode. > > "#interrupt-cells": > const: 1 > @@ -98,11 +107,15 @@ properties: > mediatek,mcm: > type: boolean > description: > - if defined, indicates that either MT7530 is the part on multi-chip > - module belong to MT7623A has or the remotely standalone chip as the > - function MT7623N reference board provided for. > + Used for MT7621AT, MT7621DAT, MT7621ST and MT7623AI SoCs which the MT7530 > + switch is a part of the multi-chip module. Does this mean it is valid only on these variants? If yes, this should have a "mediatek,mcm:false" in allOf:if:then as separate patch (with this change in description). > > reset-gpios: > + description: > + GPIO to reset the switch. Use this if mediatek,mcm is not used. The same. Example: https://elixir.bootlin.com/linux/v5.17-rc2/source/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml#L155 > + This property is optional because some boards share the reset line with > + other components which makes it impossible to probe the switch if the > + reset line is used. > maxItems: 1 > > reset-names: > @@ -148,7 +161,7 @@ required: > - reg > > allOf: > - - $ref: "dsa.yaml#" > + - $ref: dsa.yaml# > - if: > required: > - mediatek,mcm Best regards, Krzysztof