From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79424C4167B for ; Mon, 4 Apr 2022 21:49:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381296AbiDDVtq (ORCPT ); Mon, 4 Apr 2022 17:49:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378934AbiDDQFr (ORCPT ); Mon, 4 Apr 2022 12:05:47 -0400 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC5A65FCF; Mon, 4 Apr 2022 09:03:50 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 833493202095; Mon, 4 Apr 2022 12:03:49 -0400 (EDT) Received: from imap47 ([10.202.2.97]) by compute2.internal (MEProxy); Mon, 04 Apr 2022 12:03:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; bh=Y6KHhDh8XVbITNKpPkBdfRMqiixqEi mY4/vwsj86fOY=; b=Wtpvwzu9NelImDQlw+nG7GantCLueWJRosM6qGR2PtbZiN XbVKQ23pDtKfWOVOSNGB4CoP4M9TwjGuV2sb+VRA+TEIpczs/odES+yA0EW6gxRe 3SR9p/F4L5CeX0yMtQYO5TxxWX0L69gztC+OaEQ6mIyAwdDpYwhrBHx1DThd9UJJ c5VAWqnJNX50IAc3UOyk1rk5rfDnhnUypProCJL7Gx1OuGTOA+w9ODbqrLVrUFB4 RPmFTkL8W6/c6ggtQvwX4kiEdfUKTnmcDJFW2mv/yAU2p+VeLhEx3uAkjpce8FLJ iH+maBYgBCyvYZ+e7exFwAYbrTbUpydBKUrGNJsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Y6KHhDh8XVbITNKpP kBdfRMqiixqEimY4/vwsj86fOY=; b=k8uYT3/KIGaYjbi3384GuWSMawdmLMMGN eQZzj5VIP0HsjkKU9kEXOckaeGlmXLigB+ZvSPoOtUduzaoxgEvqBP+veI+Q+4Br 3rZ6svyRpy1gHJOi/cI+HjQblGTaj3J1Dlim1FT5AWGH0aQsvKrVAbO0LiLfKpLP eWFY+HKd95YUsmooHA6h6UrUh3xJ0/w6/Or5t+X2cuimR5kltaZzyNFfrm3KUO84 kVGRs2rRtBM3nP1dptQJda3gTEBZJs6Duo7HmR6yLldNpmWiOQ//mqTlJiTdeVjR BNsd6dP27wkhMaNbTnK65THDUXCOSYGx+MpnIY09NudPqpY8ErHbQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejvddgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdfuvhgv nhcurfgvthgvrhdfuceoshhvvghnsehsvhgvnhhpvghtvghrrdguvghvqeenucggtffrrg htthgvrhhnpefgieegieffuefhtedtjefgteejteefleefgfefgfdvvddtgffhffduhedv feekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hsvhgvnhesshhvvghnphgvthgvrhdruggvvh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 73F2827407D4; Mon, 4 Apr 2022 12:03:48 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-382-g88b93171a9-fm-20220330.001-g88b93171 Mime-Version: 1.0 Message-Id: In-Reply-To: <20220404155924.GA9764@lst.de> References: <20220321165049.35985-1-sven@svenpeter.dev> <20220321165049.35985-7-sven@svenpeter.dev> <20220324061620.GA12330@lst.de> <18f3a7e6-16d1-2037-90e7-1c0b1b2fbb1c@marcan.st> <20220404155924.GA9764@lst.de> Date: Mon, 04 Apr 2022 18:03:28 +0200 From: "Sven Peter" To: "hch@lst.de" , "Hector Martin" Cc: "Keith Busch" , "axboe@fb.com" , "sagi@grimberg.me" , "Alyssa Rosenzweig" , "Rob Herring" , "Arnd Bergmann" , "Marc Zyngier" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 6/9] nvme-apple: Add initial Apple SoC NVMe driver Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 4, 2022, at 17:59, Christoph Hellwig wrote: > On Tue, Apr 05, 2022 at 12:57:33AM +0900, Hector Martin wrote: >> The kernel hard limit is 100-character lines, not 80-character lines. >> Maintainers for existing drivers are certainly free to stick to 80 chars >> if they like it that way, but I don't see why we should still be >> enforcing that for new code. See bdc48fa11e46. > > Because 100 is completely utterly unreadable if is not for individual > lines like strings, and that is actually how Linus stated it in CodingStyle. > > Your code as-is is completely unreadable and will not go into > drivers/nvme/ in that form. fwiw, I wrote that code and I just forgot to check the line length after some last minute changes again. It's already been reduced to 80 chars in my local tree. Sven