From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18227C433B4 for ; Tue, 6 Apr 2021 17:57:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E151B613DE for ; Tue, 6 Apr 2021 17:57:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234631AbhDFR5z (ORCPT ); Tue, 6 Apr 2021 13:57:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:43794 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234333AbhDFR5y (ORCPT ); Tue, 6 Apr 2021 13:57:54 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DECA4B230; Tue, 6 Apr 2021 17:57:45 +0000 (UTC) MIME-Version: 1.0 Date: Tue, 06 Apr 2021 19:57:41 +0200 From: Oscar Salvador To: Mike Kravetz Cc: Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Roman Gushchin , Shakeel Butt , David Hildenbrand , Muchun Song , David Rientjes , Miaohe Lin , Peter Zijlstra , Matthew Wilcox , HORIGUCHI NAOYA , "Aneesh Kumar K . V" , Waiman Long , Peter Xu , Mina Almasry , Hillf Danton , Joonsoo Kim , Barry Song , Will Deacon , Andrew Morton Subject: Re: [PATCH v4 4/8] hugetlb: create remove_hugetlb_page() to separate functionality In-Reply-To: References: <20210405230043.182734-1-mike.kravetz@oracle.com> <20210405230043.182734-5-mike.kravetz@oracle.com> User-Agent: Roundcube Webmail Message-ID: X-Sender: osalvador@suse.de Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-04-06 18:49, Mike Kravetz wrote: > > Andrew, can we make this happen? It would require removing Oscar's > series until it can be modified to work on top of this. > There is only one small issue with this series as it originally went > into mmotm. There is a missing conversion of spin_lock to > spin_lock_irq > in patch 7. In addition, there are some suggested changes from Oscar > to > this patch. I do not think they are necessary, but I could make those > as well. Let me know what I can do to help make this happen. I agree that it might not be necesary to make such changes, but I still would like to see an explanation on the points I raised(excluding the list_del() as you already proved that is not necesary), just to be sure I am not missing anything. -- Oscar Salvador SUSE L3