linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Alban <albeu@free.fr>,
	QCA ath9k Development <ath9k-devel@qca.qualcomm.com>
Cc: John Crispin <john@phrozen.org>,
	Kalle Valo <kvalo@codeaurora.org>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] ath9k: of: Use the clk API to get the reference clock rate
Date: Mon, 13 Mar 2017 23:17:58 +0100	[thread overview]
Message-ID: <cc9f5389-7284-1269-7cf4-9ff2a2d692c0@gmail.com> (raw)
In-Reply-To: <1489439116-4233-5-git-send-email-albeu@free.fr>

On 03/13/2017 10:05 PM, Alban wrote:
> @@ -573,6 +575,12 @@ static int ath9k_of_init(struct ath_softc *sc)
>
>  	ath_dbg(common, CONFIG, "parsing configuration from OF node\n");
>
> +	clk = clk_get(sc->dev, "ref");
> +	if (!IS_ERR(clk)) {
> +		ah->is_clk_25mhz = (clk_get_rate(clk) == 25000000);

One trivial thing: you don't need these extra braces.


> +		clk_put(clk);
> +	}

  reply	other threads:[~2017-03-13 22:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-13 21:05 [PATCH 1/7] Documentation: dt: net: Update the ath9k binding for SoC devices Alban
2017-03-13 21:05 ` [PATCH 2/7] ath9k: ahb: Add OF support Alban
2017-03-14 11:17   ` Sergei Shtylyov
2017-03-13 21:05 ` [PATCH 3/7] ath9k: Add support for reading the EEPROM data using the nvmem API Alban
2017-03-13 22:17   ` Rafał Miłecki
2017-03-13 23:53   ` Christian Lamparter
2017-03-23 14:43     ` Alban
2017-03-24 16:24       ` Christian Lamparter
2017-03-13 21:05 ` [PATCH 4/7] ath9k: Add support for reading the MAC address with nvmem Alban
2017-03-13 21:05 ` [PATCH 5/7] ath9k: of: Use the clk API to get the reference clock rate Alban
2017-03-13 22:17   ` Rafał Miłecki [this message]
2017-03-13 21:05 ` [PATCH 6/7] ath9k: Allow using the reset API for the external reset Alban
2017-03-13 21:05 ` [PATCH 7/7] ath9k: hw: Reset the device with the external reset before init Alban
2017-03-20 22:06 ` [PATCH 1/7] Documentation: dt: net: Update the ath9k binding for SoC devices Rob Herring
2017-03-27 16:11 ` Christian Lamparter
2017-03-28  8:44   ` Alban
2017-03-28 14:53     ` Christian Lamparter
2017-03-28 15:18       ` Andrew Lunn
2017-03-28 16:21         ` Christian Lamparter
2017-03-28 16:41           ` Andrew Lunn
2017-03-28 17:09             ` Christian Lamparter
2017-04-05 10:09 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc9f5389-7284-1269-7cf4-9ff2a2d692c0@gmail.com \
    --to=zajec5@gmail.com \
    --cc=albeu@free.fr \
    --cc=ath9k-devel@qca.qualcomm.com \
    --cc=john@phrozen.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).