From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72300C76196 for ; Fri, 31 Mar 2023 11:35:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232063AbjCaLfJ (ORCPT ); Fri, 31 Mar 2023 07:35:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232069AbjCaLe5 (ORCPT ); Fri, 31 Mar 2023 07:34:57 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23B661EFD8; Fri, 31 Mar 2023 04:34:39 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32VBYXHL081175; Fri, 31 Mar 2023 06:34:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1680262473; bh=GvCcYXn6ovoAura2uB/dpDoFgd16j6cQ/c1lMJFYme4=; h=Date:Subject:From:To:CC:References:In-Reply-To; b=AJ10w/SaEiUKg/SVuJPLY4cO9HhIX8CAB/QB3lfUx4SML5yZydsWkeLwOu0jQEYXR OLyHoDd8yKjWvLj0Y+6ILzFCmda05Bsuq+vMWFSJl0ngJ7JgDrZsHNBCtcHce7awsR EU7mIBhB+XaGFP7DbHrzUElKoLyKhv57B5wMNEu4= Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32VBYXVj028519 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 31 Mar 2023 06:34:33 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 31 Mar 2023 06:34:33 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 31 Mar 2023 06:34:32 -0500 Received: from [10.24.69.114] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32VBYRIv123330; Fri, 31 Mar 2023 06:34:28 -0500 Message-ID: Date: Fri, 31 Mar 2023 17:04:27 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [EXTERNAL] Re: [PATCH v5 3/5] soc: ti: pruss: Add pruss_cfg_read()/update() API Content-Language: en-US From: Md Danish Anwar To: Mathieu Poirier CC: MD Danish Anwar , "Andrew F. Davis" , Suman Anna , Roger Quadros , Vignesh Raghavendra , Tero Kristo , Bjorn Andersson , Santosh Shilimkar , Nishanth Menon , , , , , , , References: <20230323062451.2925996-1-danishanwar@ti.com> <20230323062451.2925996-4-danishanwar@ti.com> <20230327210126.GC3158115@p14s> <4e239000-c5f7-a42e-157e-5b668c6b2908@ti.com> <10ad5344-e8ae-eb8e-eb1e-6431b3e09384@ti.com> Organization: Texas Instruments In-Reply-To: <10ad5344-e8ae-eb8e-eb1e-6431b3e09384@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mathieu, On 31/03/23 15:52, Md Danish Anwar wrote: > On 30/03/23 19:51, Mathieu Poirier wrote: >> On Thu, 30 Mar 2023 at 04:00, Md Danish Anwar wrote: >>> >>> Hi Mathieu, >>> >>> On 28/03/23 02:31, Mathieu Poirier wrote: >>>> On Thu, Mar 23, 2023 at 11:54:49AM +0530, MD Danish Anwar wrote: >>>>> From: Suman Anna >>>>> >>>>> Add two new generic API pruss_cfg_read() and pruss_cfg_update() to >>>>> the PRUSS platform driver to read and program respectively a register >>>>> within the PRUSS CFG sub-module represented by a syscon driver. >>>>> >>>>> These APIs are internal to PRUSS driver. Various useful registers >>>>> and macros for certain register bit-fields and their values have also >>>>> been added. >>>>> >>>>> Signed-off-by: Suman Anna >>>>> Co-developed-by: Grzegorz Jaszczyk >>>>> Signed-off-by: Grzegorz Jaszczyk >>>>> Signed-off-by: Puranjay Mohan >>>>> Signed-off-by: MD Danish Anwar >>>>> --- >>>>> drivers/soc/ti/pruss.c | 1 + >>>>> drivers/soc/ti/pruss.h | 112 +++++++++++++++++++++++++++++++++++++++++ >>>>> 2 files changed, 113 insertions(+) >>>>> create mode 100644 drivers/soc/ti/pruss.h >>>>> >>>> >>>> This patch doesn't compile without warnings. >>>> >>> >>> I checked the warnings. Below are the warnings that I am getting for these patch. >>> >>> In file included from drivers/soc/ti/pruss.c:24: >>> drivers/soc/ti/pruss.h:103:12: warning: ‘pruss_cfg_update’ defined but not used >>> [-Wunused-function] >>> 103 | static int pruss_cfg_update(struct pruss *pruss, unsigned int reg, >>> | ^~~~~~~~~~~~~~~~ >>> drivers/soc/ti/pruss.h:84:12: warning: ‘pruss_cfg_read’ defined but not used >>> [-Wunused-function] >>> 84 | static int pruss_cfg_read(struct pruss *pruss, unsigned int reg, >>> unsigned int *val) >>> >>> These warnings are coming because pruss_cfg_read() / update() APIs are >>> introduced in this patch but they are used later. >>> >>> One way to resolve this warning is to make this API "inline". I compiled after >>> making these APIs inline, it got compiled without any warnings. >>> >>> The other solution is to merge a user API of these APIs in this patch. Patch 4 >>> and 5 introduces some APIs that uses pruss_cfg_read() / update() APIs. If we >>> squash patch 5 (as patch 5 uses both read() and update() APIs where as patch 4 >>> only uses update() API) with this patch and make it a single patch where >>> pruss_cfg_read() / update() is introduced as well as used, then this warning >>> will be resolved. >>> >> >> The proper way to do this is to introduce new APIs only when they are needed. >> > > Sure, Mathieu. I will squash this patch with patch 5 ( as it uses both update() > and read() APIs) so that these APIs are introduced and used in the same patch. > I have sent next revision [v6] of these patch-set addressing your comments. Please have a look at that. [v6] https://lore.kernel.org/all/20230331112941.823410-1-danishanwar@ti.com/ -- Thanks and Regards, Danish.