From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9776BC49ED7 for ; Fri, 20 Sep 2019 06:31:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 646EE2080F for ; Fri, 20 Sep 2019 06:31:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394795AbfITGbc (ORCPT ); Fri, 20 Sep 2019 02:31:32 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:55844 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388940AbfITGbc (ORCPT ); Fri, 20 Sep 2019 02:31:32 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 021F0F182499586AC685; Fri, 20 Sep 2019 14:31:30 +0800 (CST) Received: from [127.0.0.1] (10.133.217.137) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.439.0; Fri, 20 Sep 2019 14:31:27 +0800 Subject: Re: [PATCH 18/32] platform/x86: Use pr_warn instead of pr_warning To: Andy Shevchenko CC: Joe Perches , Andrew Morton , Ingo Molnar , "David S. Miller" , Arnaldo Carvalho de Melo , Andy Whitcroft , Peter Zijlstra , "Alexei Starovoitov" , Daniel Borkmann , "Greg Kroah-Hartman" , Sergey Senozhatsky , Petr Mladek , Arnd Bergmann , Linux Kernel Mailing List , Corentin Chary , Darren Hart , Andy Shevchenko References: <20190920062544.180997-1-wangkefeng.wang@huawei.com> <20190920062544.180997-19-wangkefeng.wang@huawei.com> From: Kefeng Wang Message-ID: Date: Fri, 20 Sep 2019 14:31:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.133.217.137] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/9/20 14:26, Andy Shevchenko wrote: > On Fri, Sep 20, 2019 at 9:10 AM Kefeng Wang wrote: >> As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of >> pr_warning"), removing pr_warning so all logging messages use a >> consistent _warn style. Let's do it. >> > Please, split on three patches (per driver). ok, will send v2, thanks. > >> drivers/platform/x86/asus-laptop.c | 2 +- >> drivers/platform/x86/eeepc-laptop.c | 2 +- >> drivers/platform/x86/intel_oaktrail.c | 10 +++++-----