From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91BB9C54E94 for ; Wed, 25 Jan 2023 11:14:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235739AbjAYLO0 (ORCPT ); Wed, 25 Jan 2023 06:14:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235734AbjAYLN6 (ORCPT ); Wed, 25 Jan 2023 06:13:58 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 217ED58654 for ; Wed, 25 Jan 2023 03:13:47 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id f19-20020a1c6a13000000b003db0ef4dedcso965507wmc.4 for ; Wed, 25 Jan 2023 03:13:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=azSPw3xKSo7B7wtu20Ypk0qIeinHqT2sve8f6K2slzY=; b=laTv96FmGN2CDnMnNgZcThObgd6kGayNKDk5sXPbWY4MlJ8WLZQQUZ/HBZHRlrYwTb ngfPj1aP2sq0OwMr8YxypQg/JfRyQHeBBmQmjt81FRPYsG6fNkufWBRb2W2dhF9T+yjb Xfur+XUoinDZOLhJuYmKxRxzvP6bKIXQEyF4j4YhQMk8Kdh60FXrFFWoesb3sm1KT9pI c5u+GQGEsfxQWk4QKSE+wrA05wedUJN6cW/ePldUoVaEOm/O2MfkJ8jw/ckoOLbMD1iQ Ry9DA2Uf0nMc2iQWVDw039CLCPo9L6GbynjpeAn0PljjXOetj0I3C/gsvu7eni4sUKzJ mlTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=azSPw3xKSo7B7wtu20Ypk0qIeinHqT2sve8f6K2slzY=; b=By9E0ZzXS4ZNlKWgUaizjWMRyPaDyUvYUu3N97cjm6if49vAyr5r7YbuKn4bRRujJ0 wSUSPCdPYaJk2XFgfv1gg3Xv6CoQBk2oAK+H80Mlh3PLqz7Nu47/3jJ+SjzqtIdz7Fq9 Mv/BeWYOdBZIlOiEVkdFhETswZ7sGCpwavcJrVETMaZB/uO6+XuGvWNmtpZ7WeKCl/ab zlgt/Bj1L93yUya+dHVgRWSwGHK2tRE/1T4gUFEVdRj1aUPx713VWe8GNeGlU7hBS0SL Ue+3edobDnrQMPPcci9A3w6d0l1/aYTwj90w+ZcNOujWQcOds5egE19kI/RpRKGixf1j VWEw== X-Gm-Message-State: AFqh2kqlNA7cXhGvWAR0sCrUYsKyTjiETWVSoIgMNBNER7Mpcu/j5s4y fv4NIKslbeEDk1FVGvAWCwR40A== X-Google-Smtp-Source: AMrXdXv/ioghEmSSNlplJGgotjqdQ9osMujFVj2dNQKJWKJWQejUfnANRvec9R3Rbg8+lTOoQBkHxQ== X-Received: by 2002:a7b:c45a:0:b0:3d1:ed41:57c0 with SMTP id l26-20020a7bc45a000000b003d1ed4157c0mr39148591wmi.30.1674645225637; Wed, 25 Jan 2023 03:13:45 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id p23-20020a1c5457000000b003da286f8332sm1380553wmi.18.2023.01.25.03.13.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 03:13:45 -0800 (PST) Message-ID: Date: Wed, 25 Jan 2023 12:13:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 04/10] dt-bindings: clock: Add Qualcomm IPQ5332 GCC Content-Language: en-US To: Kathiravan Thirumoorthy , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, ulf.hansson@linaro.org, linus.walleij@linaro.org, catalin.marinas@arm.com, will@kernel.org, shawnguo@kernel.org, arnd@arndb.de, marcel.ziswiler@toradex.com, dmitry.baryshkov@linaro.org, nfraprado@collabora.com, broonie@kernel.org, robimarko@gmail.com, quic_gurus@quicinc.com, bhupesh.sharma@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230125104520.89684-1-quic_kathirav@quicinc.com> <20230125104520.89684-5-quic_kathirav@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230125104520.89684-5-quic_kathirav@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/01/2023 11:45, Kathiravan Thirumoorthy wrote: > From: Kathiravan T > > Add binding for the Qualcomm IPQ5332 Global Clock Controller. > > Signed-off-by: Kathiravan T > --- Thank you for your patch. There is something to discuss/improve. > + clocks: > + items: > + - description: Board XO clock source > + - description: Sleep clock source > + - description: PCIE 2lane PHY pipe clock source > + - description: PCIE 2lane x1 PHY pipe clock source (For second lane) > + - description: USB PCIE wrapper pipe clock source > + > + clock-names: > + items: > + - const: xo > + - const: sleep_clk > + - const: pcie_2lane_phy_pipe_clk > + - const: pcie_2lane_phy_pipe_clk_x1 > + - const: usb_pcie_wrapper_pipe_clk > + > +required: > + - compatible clocks are required > + > +unevaluatedProperties: false > + > +examples: > + - | > + clock-controller@1800000 { > + compatible = "qcom,ipq5332-gcc"; > + reg = <0x01800000 0x80000>; > + #clock-cells = <1>; > + #power-domain-cells = <1>; > + #reset-cells = <1>; > + }; > +... > diff --git a/include/dt-bindings/clock/qcom,gcc-ipq5332.h b/include/dt-bindings/clock/qcom,gcc-ipq5332.h > new file mode 100644 > index 000000000000..a305c648b724 > --- /dev/null > +++ b/include/dt-bindings/clock/qcom,gcc-ipq5332.h Filename should match bindings/compatible. Best regards, Krzysztof