From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E84E1C433FE for ; Mon, 28 Nov 2022 20:59:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233469AbiK1U7Q (ORCPT ); Mon, 28 Nov 2022 15:59:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233067AbiK1U7N (ORCPT ); Mon, 28 Nov 2022 15:59:13 -0500 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB20220347 for ; Mon, 28 Nov 2022 12:59:09 -0800 (PST) Received: by mail-lf1-x129.google.com with SMTP id d6so19364260lfs.10 for ; Mon, 28 Nov 2022 12:59:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=amrhtMYz1fcMT4774lJ3IkoPUekKuEb1D1Fr4wm8cyE=; b=mWJIJPx7w727Kxagcg85gL8GhE0Wr+zkYB2aPxVBSV5pvOgLtAJI/kgxjI3Vhyg9cg A6cqL0mdiyD57ho0wUaz++izY8F1kQFBy4jA2e8FGggxpDqVISTqT8VVLC+/62vTnaQv QHt2rfZNGfIiloqZ8Zlos1JwmlZJ/T7qou+VH/xP9qcnim8A6se9w+aCSDiXu42hnkR7 MWRTdrILBKUFyezpukTfgPqd38c0hTxWBHxf4cKiJiA+IUdVN+kX7LHIU7RYxS6TE/tZ hK1rfxLtEKS22EfUd+3bvxeTy1vl7F7OV+H7maVfaLUHFazPo+x0KPIaB6uAFXx1kAU0 kf/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=amrhtMYz1fcMT4774lJ3IkoPUekKuEb1D1Fr4wm8cyE=; b=VjXB8EPnyj1j78JiVxlRzvFoLdONGFuT/HmtL+5tKt8/UMfl24oPP7ooCGkCkK7FCZ iPy64rcVou/tWZzXshNP2CQaMd0IN/Xvh8y00j8I5GZ4bmYvlW35yptXASuxWwQj5jUD pvYvq8aRzzRadQUloaWl1JkfhNoPSeZ/XfRM58Tp4E8UVGIVLVZ1ZOam3NYGEv3g3IDu UQgixH6EbtKdw2AfYdsKIIE22vSJYXQzBm/4tjjah6VUH46omk8mr3iX0qI+18JhGZX8 dgV/4cwWt2aH10dtaKVpBTYsKg6MQZk+Gdjem0pdxkKKFSKjGlBm5bdMZSJ8tGPRsF/3 LEtQ== X-Gm-Message-State: ANoB5pllCxxQqPhKgJYUZAx2lwhw1HatEIkCFRUYXhMIErauIr1b0EMo pgMmm/MF+OoN/jvA0VphLGOwrw== X-Google-Smtp-Source: AA0mqf6oWRYjzBqJxXLUJBEC/gj0sxdcJPuMtpZ1+2l0/UHjHaaDlf6ek+9eTPQ9E3umSLeOAbPFew== X-Received: by 2002:a19:791c:0:b0:4b4:dd9:1880 with SMTP id u28-20020a19791c000000b004b40dd91880mr12162177lfc.289.1669669147898; Mon, 28 Nov 2022 12:59:07 -0800 (PST) Received: from [192.168.1.101] (95.49.125.236.neoplus.adsl.tpnet.pl. [95.49.125.236]) by smtp.gmail.com with ESMTPSA id q21-20020a056512211500b00492dc29be7bsm1872005lfr.227.2022.11.28.12.59.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 12:59:07 -0800 (PST) Message-ID: Date: Mon, 28 Nov 2022 21:59:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Enable ADSP Content-Language: en-US To: =?UTF-8?Q?Matti_Lehtim=c3=a4ki?= , linux-arm-msm@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221125223400.94515-1-matti.lehtimaki@gmail.com> <90d231c6-1f16-74ea-ddf7-5e09a51a93ea@gmail.com> From: Konrad Dybcio In-Reply-To: <90d231c6-1f16-74ea-ddf7-5e09a51a93ea@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.11.2022 18:01, Matti Lehtimäki wrote: > On 28.11.2022 16.41, Konrad Dybcio wrote: >> >> On 25.11.2022 23:34, Matti Lehtimäki wrote: >>> diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts >>> index 1c52337af560..859e91c16c61 100644 >>> --- a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts >>> +++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts >>> @@ -133,7 +133,8 @@ wcnss@d200000 { >>>               no-map; >>>           }; >>>   -        adsp@d900000 { >>> +        /delete-node/ adsp@dc00000; >> Please delete nodes by referencing the label like so: >> >> /delete-node/ &adsp_region; > > When I created the devicetree I was asked to do the opposite for the > smem_region [1] which I had originally deleted using the label near top of the > file but then moved next to the relevant node, where I cannot use label > when deleting it. Should the smem_region also be moved to the top of the > file if I move this delete-node there so the file would be consistent? In [1] you were asked to move the delete-node statement, not to alter the argument. Referencing nodes by label is allowed globally in the DTS. The removal should stay inside reserved-memory. Konrad > > [1] https://lore.kernel.org/linux-arm-msm/CAA8EJpqUH_v1GXEYF62Z3DBtFu_305_h4D36aCnBr38bo5HoJw@mail.gmail.com/