From: Katsuhiro Suzuki <katsuhiro@katsuster.net>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: rockchip: add ethernet phy node for tinker board
Date: Sat, 22 Jun 2019 23:50:10 +0900 [thread overview]
Message-ID: <ccf5ad2c-bd56-2d77-4728-d7906045e302@katsuster.net> (raw)
In-Reply-To: <1871177.hjLhdHVgcu@phil>
Hello,
Current linux-next on my environment, 'ifconfig eth0 up' does not
work correctly with following message...
-----
root@linaro-alip:~# ifconfig eth0 up
[ 105.028916] rk_gmac-dwmac ff290000.ethernet eth0: stmmac_open: Cannot
attach to PHY (error: -19)
SIOCSIFFLAGS: No such device
-----
I checked drivers/net/ethernet/stmicro/stmmac/stmmac_main.c and found
stmmac_init_phy() is going to fail if ethernet device node does not
have following property:
- phy-handle
- phy
- phy-device
I salvaged old version of linux-next kernel (5.2.0-rc1-20190523),
network device of my Tinker Board worked correctly if use it.
I have not bisect commit of root cause yet... Is it better to bisect
and find problem instead of sending this patch?
Best Regards,
---
Katsuhiro Suzuki
On 2019/06/22 17:33, Heiko Stuebner wrote:
> Hi,
>
> Am Freitag, 21. Juni 2019, 20:00:17 CEST schrieb Katsuhiro Suzuki:
>> This patch adds missing mdio and ethernet PHY nodes for rk3328 ASUS
>> tinker board.
>>
>> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
>
> just for my understanding, which problem does this solve?
> Normally the gmac can establish connections just fine on
> the rk3288 by probing the phy in the automatic way.
>
> And I also don't see any additional properties like phy
> interrupt line below.
>
>
> Thanks
> Heiko
>
>> ---
>> arch/arm/boot/dts/rk3288-tinker.dtsi | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi b/arch/arm/boot/dts/rk3288-tinker.dtsi
>> index 293576869546..3190817e8d5d 100644
>> --- a/arch/arm/boot/dts/rk3288-tinker.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-tinker.dtsi
>> @@ -117,6 +117,7 @@
>> assigned-clocks = <&cru SCLK_MAC>;
>> assigned-clock-parents = <&ext_gmac>;
>> clock_in_out = "input";
>> + phy-handle = <&phy0>;
>> phy-mode = "rgmii";
>> phy-supply = <&vcc33_lan>;
>> pinctrl-names = "default";
>> @@ -127,6 +128,17 @@
>> tx_delay = <0x30>;
>> rx_delay = <0x10>;
>> status = "ok";
>> +
>> + mdio0 {
>> + compatible = "snps,dwmac-mdio";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + phy0: ethernet-phy@0 {
>> + compatible = "ethernet-phy-ieee802.3-c22";
>> + reg = <0>;
>> + };
>> + };
>> };
>>
>> &gpu {
>>
>
>
>
>
>
next prev parent reply other threads:[~2019-06-22 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 18:00 [PATCH] ARM: dts: rockchip: add ethernet phy node for tinker board Katsuhiro Suzuki
2019-06-22 8:33 ` Heiko Stuebner
2019-06-22 14:50 ` Katsuhiro Suzuki [this message]
2019-06-22 15:15 ` Heiko Stuebner
2019-06-22 17:55 ` Andrew Lunn
2019-06-23 13:31 ` Katsuhiro Suzuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccf5ad2c-bd56-2d77-4728-d7906045e302@katsuster.net \
--to=katsuhiro@katsuster.net \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).