From: Kirti Wankhede <kwankhede@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: <jike.song@intel.com>, <linux-kernel@vger.kernel.org>,
<kvm@vger.kernel.org>
Subject: Re: [PATCH v2 0/4] vfio-mdev: Fix remove race, clean namespace and better define ABI
Date: Mon, 26 Dec 2016 09:01:35 +0530 [thread overview]
Message-ID: <cd0a8b63-ebe4-b0b8-d59d-26dbbf3b75c7@nvidia.com> (raw)
In-Reply-To: <20161222201809.15541.22506.stgit@gimli.home>
On 12/23/2016 1:51 AM, Alex Williamson wrote:
> Cleanup the namespace a bit by prefixing structures with mdev_ and
> also more concretely define the mdev interface. Structs with comments
> defining which fields are private vs public tempts poor behavior,
> especially for an interface where we expect out of tree vendor drivers.
>
Patch 2/4-4/4 looks good to me.
Reviewed by: Kirti Wankhede <kwankhede@nvidia.com>
Thanks,
Kirti
> Additionally in v2, the patch removing the next field from mdev_device
> is dropped, instead using it to fix a remove race, my From address is
> fixed, and Documentation is updated. Jike, I left your R-b on the
> patches that didn't change only. If I've missed any relevant doc
> updates, please let me know. Thanks,
>
> Alex
>
> ---
>
> Alex Williamson (4):
> vfio-mdev: Fix remove race
> vfio-mdev: de-polute the namespace, rename parent_device & parent_ops
> vfio-mdev: Make mdev_parent private
> vfio-mdev: Make mdev_device private and abstract interfaces
>
>
> Documentation/vfio-mediated-device.txt | 27 +++++----
> drivers/gpu/drm/i915/gvt/kvmgt.c | 22 ++++---
> drivers/vfio/mdev/mdev_core.c | 100 +++++++++++++++++++++++++++-----
> drivers/vfio/mdev/mdev_private.h | 29 ++++++++-
> drivers/vfio/mdev/mdev_sysfs.c | 8 +--
> drivers/vfio/mdev/vfio_mdev.c | 12 ++--
> include/linux/mdev.h | 54 ++++-------------
> samples/vfio-mdev/mtty.c | 28 +++++----
> 8 files changed, 173 insertions(+), 107 deletions(-)
>
prev parent reply other threads:[~2016-12-26 3:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 20:21 [PATCH v2 0/4] vfio-mdev: Fix remove race, clean namespace and better define ABI Alex Williamson
2016-12-22 20:21 ` [PATCH v2 1/4] vfio-mdev: Fix remove race Alex Williamson
2016-12-25 17:09 ` Kirti Wankhede
2016-12-25 19:40 ` Alex Williamson
2016-12-26 3:28 ` Kirti Wankhede
2016-12-22 20:22 ` [PATCH v2 2/4] vfio-mdev: de-polute the namespace, rename parent_device & parent_ops Alex Williamson
2016-12-22 20:22 ` [PATCH v2 3/4] vfio-mdev: Make mdev_parent private Alex Williamson
2016-12-22 20:22 ` [PATCH v2 4/4] vfio-mdev: Make mdev_device private and abstract interfaces Alex Williamson
2016-12-26 3:31 ` Kirti Wankhede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd0a8b63-ebe4-b0b8-d59d-26dbbf3b75c7@nvidia.com \
--to=kwankhede@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=jike.song@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).