From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91CB8C43334 for ; Wed, 1 Jun 2022 23:57:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232666AbiFAX5v (ORCPT ); Wed, 1 Jun 2022 19:57:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232655AbiFAX5q (ORCPT ); Wed, 1 Jun 2022 19:57:46 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ED67280F2C for ; Wed, 1 Jun 2022 16:57:45 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id c2so3146307plh.2 for ; Wed, 01 Jun 2022 16:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=2XYIiNyPAxUCbPTW69gSeTjEEL/1p7bXfOfkRP2R+fc=; b=AnVtflFbxLoXdOq9BIgNzWOJWX5MjLy5hTpl10niEjW/MiLfkhVpK/bYI4PNqt+hXL CndBf+09kS+cPl/8TKkLg1gCenAXWq7DZXfTDhyfmBw1f2r9AZ7TnlxY2owMbEg7vIuX eZBe+mDq7MnY2egmLsIh/foumg7cvgUEOX36FX01x9dUIsgpY1sD/10/K45uSuLxS5Xl oFqSvLV9R6p24dJ5kBOhFU4Z/DlNGgijY4aPr7Z72wgUFxfe2/LwZY4SEjeg6X3h3Fw+ AB34r+vkLrWYYnCTT7Iv0Bg49Aa3hxHQZGDpnrBG1tMSUscRxjT0FG6abSwGLZsK5CtJ NSbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=2XYIiNyPAxUCbPTW69gSeTjEEL/1p7bXfOfkRP2R+fc=; b=SuQ0odTLCDasopI50IAjRjBjYFAytEwQDptt7tofpT1GbwZ24xgCyngFEKSfxgQDQ5 PYc/RXEbi7+wXT7QG2Xk+oGN6zJCtFNyAK5wiDwGpQirKIZLEUGGmr2e30tRuQloYcI7 LJxp/nSZ2mlZ7A1JjBTjfHVlH1NA1etcIT73PNnsQq30Y5mb3MVYQ9WdKxJfnmraYfqI UNsrpu/qw5t/T4J3zeJb0VyFvXmdT4f9l9fSkTK1xWpnxRubkgjZEbNCwAx+Pz//C1Dh cKbvEwJOc7xOkZ4iSBXOeXAY+cHTfbIpGY0n5hTlSJ2zJjYy1JNEf9WrWXAYm8jP4x87 ilUg== X-Gm-Message-State: AOAM530FDNa0JdYgd7RT5B3DrCafpYmmnpRI0aPsAnxLa6y95dRJkd1k 1/PhRxDwN/7nAo+vPETgZxgreg/NtVlX/Q== X-Google-Smtp-Source: ABdhPJyZ89NVGJO9n6rvyH2+UnhVOjm73j5+UWD3ThnWFMT8FpPVXYSUW9vfwDtLfITlXb6Ggo/ykQ== X-Received: by 2002:a17:90a:6441:b0:1e0:b413:c290 with SMTP id y1-20020a17090a644100b001e0b413c290mr36860926pjm.179.1654127864974; Wed, 01 Jun 2022 16:57:44 -0700 (PDT) Received: from ?IPV6:2409:8a28:e67:690:38d5:dec6:94e6:8d4b? ([2409:8a28:e67:690:38d5:dec6:94e6:8d4b]) by smtp.gmail.com with ESMTPSA id t17-20020a62ea11000000b0051874318772sm2018554pfh.201.2022.06.01.16.57.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 16:57:44 -0700 (PDT) Message-ID: Date: Thu, 2 Jun 2022 07:57:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/2] blk-iocost: only flush wait and indebt stat deltas when needed Content-Language: en-US To: Tejun Heo Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220601122007.1057-1-zhouchengming@bytedance.com> <20220601122007.1057-2-zhouchengming@bytedance.com> From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/6/2 00:23, Tejun Heo wrote: > On Wed, Jun 01, 2022 at 08:20:07PM +0800, Chengming Zhou wrote: >> We only need to flush wait and indebt stat deltas when the iocg >> is in these status. > > Hey, so, I'm not seeing any actual benefits of the suggested patches and > none of them has actual justifications. For the time being, I'm gonna be > ignoring these patches. Hi, the current code will flush wait and indebt stat deltas even for idle iocgs, which seems strange. This patch only do that for iocgs that are in wait or indebt status, so it's a performance and code improvements, although it's minor. Thanks. > > Thanks. >