From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932489AbeALHnO convert rfc822-to-8bit (ORCPT + 1 other); Fri, 12 Jan 2018 02:43:14 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:11506 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750714AbeALHnM (ORCPT ); Fri, 12 Jan 2018 02:43:12 -0500 From: Loic PALLARDY To: Bjorn Andersson CC: "ohad@wizery.com" , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Arnaud POULIQUEN , "benjamin.gaignard@linaro.org" Subject: RE: [PATCH v2 01/16] remoteproc: add rproc_va_to_pa function Thread-Topic: [PATCH v2 01/16] remoteproc: add rproc_va_to_pa function Thread-Index: AQHTafrdqSGVmBriEkqHr6wSrLbUuaNCAOMAgC4cs/A= Date: Fri, 12 Jan 2018 07:43:09 +0000 Message-ID: References: <1512060411-729-1-git-send-email-loic.pallardy@st.com> <1512060411-729-2-git-send-email-loic.pallardy@st.com> <20171214003056.GC17344@builder> In-Reply-To: <20171214003056.GC17344@builder> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.50] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-12_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi Bjorn, Thanks for the review of this series. > -----Original Message----- > From: Bjorn Andersson [mailto:bjorn.andersson@linaro.org] > Sent: Thursday, December 14, 2017 1:31 AM > To: Loic PALLARDY > Cc: ohad@wizery.com; linux-remoteproc@vger.kernel.org; linux- > kernel@vger.kernel.org; Arnaud POULIQUEN ; > benjamin.gaignard@linaro.org > Subject: Re: [PATCH v2 01/16] remoteproc: add rproc_va_to_pa function > > On Thu 30 Nov 08:46 PST 2017, Loic Pallardy wrote: > > > This new function translates CPU virtual address in > > CPU physical one according to virtual address location. > > > > Signed-off-by: Loic Pallardy > > --- > > drivers/remoteproc/remoteproc_core.c | 13 ++++++++++++- > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/remoteproc/remoteproc_core.c > b/drivers/remoteproc/remoteproc_core.c > > index eab14b4..faa18a7 100644 > > --- a/drivers/remoteproc/remoteproc_core.c > > +++ b/drivers/remoteproc/remoteproc_core.c > > @@ -139,6 +139,17 @@ static void rproc_disable_iommu(struct rproc > *rproc) > > iommu_domain_free(domain); > > } > > > > +static phys_addr_t rproc_va_to_pa(void *cpu_addr) > > +{ > > + if (is_vmalloc_addr(cpu_addr)) { > > Please add a comment describing when is_vmalloc_addr() would be true. Yes sure. Regards, Loic > > > + return page_to_phys(vmalloc_to_page(cpu_addr)) + > > + offset_in_page(cpu_addr); > > + } > > + > > + WARN_ON(!virt_addr_valid(cpu_addr)); > > + return virt_to_phys(cpu_addr); > > +} > > + > > /** > > * rproc_da_to_va() - lookup the kernel virtual address for a remoteproc > address > > * @rproc: handle of a remote processor > > @@ -700,7 +711,7 @@ static int rproc_handle_carveout(struct rproc > *rproc, > > * In this case, the device address and the physical address > > * are the same. > > */ > > - rsc->pa = dma; > > + rsc->pa = (u32)rproc_va_to_pa(va); > > This is more correct than using "dma", so this is good. > > Regards, > Bjorn