From: Joe Perches <joe@perches.com>
To: Yangtao Li <tiny.windzz@gmail.com>,
tytso@mit.edu, arnd@arndb.de, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] random: Add and use pr_fmt()
Date: Mon, 10 Jun 2019 12:12:44 -0700 [thread overview]
Message-ID: <cd2fe2492251187acf62744a191cf6d76732f9e7.camel@perches.com> (raw)
In-Reply-To: <20190607182517.28266-3-tiny.windzz@gmail.com>
On Fri, 2019-06-07 at 14:25 -0400, Yangtao Li wrote:
> Prefix all printk/pr_<level> messages with "random: " to make the
> logging a bit more consistent.
>
> Miscellanea:
>
> o Convert a printks to pr_notice
> o Whitespace to align to open parentheses
> o Remove embedded "random: " from pr_* as pr_fmt adds it
[]
> diff --git a/drivers/char/random.c b/drivers/char/random.c
[]
> @@ -1031,15 +1033,15 @@ static void crng_reseed(struct crng_state *crng, struct entropy_store *r)
> crng_init = 2;
> process_random_ready_list();
> wake_up_interruptible(&crng_init_wait);
> - pr_notice("random: crng init done\n");
> + pr_notice("crng init done\n");
> if (unseeded_warning.missed) {
> - pr_notice("random: %d get_random_xx warning(s) missed "
> + pr_notice("%d get_random_xx warning(s) missed "
> "due to ratelimiting\n",
Trivia:
It'd be nice to coalesce the format string fragments
into a single line at the same time too.
pr_notice("%d get_random_xx warning(s) missed due to ratelimiting\n",
unseeded_warning.missed);
> unseeded_warning.missed = 0;
> }
> if (urandom_warning.missed) {
> - pr_notice("random: %d urandom warning(s) missed "
> + pr_notice("%d urandom warning(s) missed "
> "due to ratelimiting\n",
etc...
next prev parent reply other threads:[~2019-06-10 19:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 18:25 [PATCH 1/5] random: remove unnecessary unlikely() Yangtao Li
2019-06-07 18:25 ` [PATCH 2/5] random: convert to ENTROPY_BITS Yangtao Li
2020-01-07 21:37 ` Theodore Y. Ts'o
2019-06-07 18:25 ` [PATCH 3/5] random: Add and use pr_fmt() Yangtao Li
2019-06-10 19:12 ` Joe Perches [this message]
2020-01-07 21:45 ` Theodore Y. Ts'o
2019-06-07 18:25 ` [PATCH 4/5] random: fix typo in add_timer_randomness() Yangtao Li
2020-01-07 22:08 ` Theodore Y. Ts'o
2019-06-07 18:25 ` [PATCH 5/5] random: remove some dead code of poolinfo Yangtao Li
2020-01-07 22:20 ` Theodore Y. Ts'o
2019-07-11 14:49 ` [PATCH 1/5] random: remove unnecessary unlikely() Frank Lee
2019-10-29 7:14 ` Joe Perches
2019-11-09 0:54 ` Joe Perches
2019-12-14 18:15 ` Frank Lee
2020-01-07 21:10 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd2fe2492251187acf62744a191cf6d76732f9e7.camel@perches.com \
--to=joe@perches.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiny.windzz@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).